Skip to content

Introduce parameter failOnMismatchedAllowedViolationsCount #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NathanEckert opened this issue May 5, 2025 · 0 comments · May be fixed by #165
Open

Introduce parameter failOnMismatchedAllowedViolationsCount #174

NathanEckert opened this issue May 5, 2025 · 0 comments · May be fixed by #165
Labels
enhancement New feature or request

Comments

@NathanEckert
Copy link

New feature, improvement proposal

Associated PR: #165

Introduce a parameter to fail the build when the number of violations is not equal to maxAllowedViolations

This prevents the following scenario:

  • some changes reduce the checkstyle count but maxAllowedViolations is not updated
  • some other changes introduces new violations but the build does not fail, as the count left some margin for error, when we would like to avoid introducing new failures
@NathanEckert NathanEckert added the enhancement New feature or request label May 5, 2025
@NathanEckert NathanEckert linked a pull request May 5, 2025 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce parameter failOnMismatchedAllowedViolationsCount NathanEckert/maven-checkstyle-plugin
1 participant
@NathanEckert