KAFKA-19101 Remove ControllerMutationQuotaManager#throttleTimeMs unused parameter (#19410)

It seems `timeMs` this parameter never used in Kafka project, the method
init commit is

b5f90da

Reviewers: Jhen-Yung Hsu <[email protected]>, PoAn Yang
<[email protected]>, TengYao Chi <[email protected]>, Chia-Ping Tsai
<[email protected]>

Author: m1a2st

core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala

@@ -61,10 +61,10 @@ object UnboundedControllerMutationQuota extends ControllerMutationQuota {
  */
 abstract class AbstractControllerMutationQuota(private val time: Time) extends ControllerMutationQuota {
   protected var lastThrottleTimeMs = 0L
-  protected var lastRecordedTimeMs = 0L
+  private var lastRecordedTimeMs = 0L
 
   protected def updateThrottleTime(e: QuotaViolationException, timeMs: Long): Unit = {
-    lastThrottleTimeMs = ControllerMutationQuotaManager.throttleTimeMs(e, timeMs)
+    lastThrottleTimeMs = ControllerMutationQuotaManager.throttleTimeMs(e)
     lastRecordedTimeMs = timeMs
   }
 
@@ -142,7 +142,7 @@ object ControllerMutationQuotaManager {
    * Basically, if a value < 0 is observed, the time required to bring it to zero is
    * -value / refill rate (quota bound) * 1000.
    */
-  def throttleTimeMs(e: QuotaViolationException, timeMs: Long): Long = {
+  def throttleTimeMs(e: QuotaViolationException): Long = {
     e.metric().measurable() match {
       case _: TokenBucket =>
         Math.round(-e.value() / e.bound() * 1000)
@@ -216,7 +216,7 @@ class ControllerMutationQuotaManager(private val config: ClientQuotaManagerConfi
       0
     } catch {
       case e: QuotaViolationException =>
-        val throttleTimeMs = ControllerMutationQuotaManager.throttleTimeMs(e, timeMs).toInt
+        val throttleTimeMs = ControllerMutationQuotaManager.throttleTimeMs(e).toInt
         debug(s"Quota violated for sensor (${quotaSensor.name}). Delay time: ($throttleTimeMs)")
         throttleTimeMs
     }

core/src/test/scala/unit/kafka/server/ControllerMutationQuotaManagerTest.scala

@@ -137,9 +137,9 @@ class ControllerMutationQuotaManagerTest extends BaseClientQuotaManagerTest {
     sensor.add(metricName, new TokenBucket)
     val metric = metrics.metric(metricName)
 
-    assertEquals(0, throttleTimeMs(new QuotaViolationException(metric, 0, 10), time.milliseconds()))
-    assertEquals(500, throttleTimeMs(new QuotaViolationException(metric, -5, 10), time.milliseconds()))
-    assertEquals(1000, throttleTimeMs(new QuotaViolationException(metric, -10, 10), time.milliseconds()))
+    assertEquals(0, throttleTimeMs(new QuotaViolationException(metric, 0, 10)))
+    assertEquals(500, throttleTimeMs(new QuotaViolationException(metric, -5, 10)))
+    assertEquals(1000, throttleTimeMs(new QuotaViolationException(metric, -10, 10)))
   }
 
   @Test