refactor(core): Add ErrorKind InvalidInput to indicate users input error (#2637)

* fix: make seek invalid error more clear

Signed-off-by: dqhl76 <[email protected]>

* fix: format file

Signed-off-by: dqhl76 <[email protected]>

---------

Signed-off-by: dqhl76 <[email protected]>

Author: dqhl76

core/src/raw/oio/cursor.rs

@@ -84,7 +84,7 @@ impl oio::Read for Cursor {
             Some(n) if n >= 0 => n as u64,
             _ => {
                 return Poll::Ready(Err(Error::new(
-                    ErrorKind::Unexpected,
+                    ErrorKind::InvalidInput,
                     "invalid seek to a negative or overflowing position",
                 )))
             }
@@ -127,7 +127,7 @@ impl oio::BlockingRead for Cursor {
             Some(n) if n >= 0 => n as u64,
             _ => {
                 return Err(Error::new(
-                    ErrorKind::Unexpected,
+                    ErrorKind::InvalidInput,
                     "invalid seek to a negative or overflowing position",
                 ))
             }

core/src/raw/oio/into_blocking_reader/from_fd.rs

@@ -90,7 +90,7 @@ where
 
         match base.checked_add(offset) {
             Some(n) if n < 0 => Err(Error::new(
-                ErrorKind::Unexpected,
+                ErrorKind::InvalidInput,
                 "invalid seek to a negative or overflowing position",
             )),
             Some(n) => {
@@ -104,7 +104,7 @@ where
                 Ok(self.offset - self.start)
             }
             None => Err(Error::new(
-                ErrorKind::Unexpected,
+                ErrorKind::InvalidInput,
                 "invalid seek to a negative or overflowing position",
             )),
         }

core/src/raw/oio/into_reader/by_range.rs

@@ -114,7 +114,7 @@ impl<A: Accessor> RangeReader<A> {
             Some(n) if n >= 0 => n as u64,
             _ => {
                 return Err(Error::new(
-                    ErrorKind::Unexpected,
+                    ErrorKind::InvalidInput,
                     "invalid seek to a negative or overflowing position",
                 ))
             }

core/src/raw/oio/into_reader/from_fd.rs

@@ -93,7 +93,7 @@ where
 
         match base.checked_add(offset) {
             Some(n) if n < 0 => Poll::Ready(Err(Error::new(
-                ErrorKind::Unexpected,
+                ErrorKind::InvalidInput,
                 "invalid seek to a negative or overflowing position",
             ))),
             Some(n) => {
@@ -109,7 +109,7 @@ where
                 Poll::Ready(Ok(self.offset - self.start))
             }
             None => Poll::Ready(Err(Error::new(
-                ErrorKind::Unexpected,
+                ErrorKind::InvalidInput,
                 "invalid seek to a negative or overflowing position",
             ))),
         }

core/src/types/error.rs

@@ -99,6 +99,10 @@ pub enum ErrorKind {
     /// - Users expected to read 1024 bytes, but service returned less bytes.
     /// - Service expected to write 1024 bytes, but users write less bytes.
     ContentIncomplete,
+    /// The input is invalid.
+    ///
+    /// For example, user try to seek to a negative position
+    InvalidInput,
 }
 
 impl ErrorKind {
@@ -130,6 +134,7 @@ impl From<ErrorKind> for &'static str {
             ErrorKind::ConditionNotMatch => "ConditionNotMatch",
             ErrorKind::ContentTruncated => "ContentTruncated",
             ErrorKind::ContentIncomplete => "ContentIncomplete",
+            ErrorKind::InvalidInput => "InvalidInput",
         }
     }
 }