Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Commit fe1c199

Browse files
authored
Added ability to disable base_url in Helm chart (#3619)
1 parent a3cda19 commit fe1c199

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

deploy/kubernetes/helm/templates/tools.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,9 @@ spec:
116116
- >-
117117
heron-ui
118118
--port=8889
119-
--base_url={{ .Values.heron.url | default $defaultUrl }}
119+
{{- if not (kindIs "invalid" .Values.heron.url) }}
120+
--base_url={{ eq .Values.heron.url "-" | ternary $defaultUrl .Values.heron.url }}
121+
{{- end }}
120122
- name: heron-apiserver
121123
image: {{ .Values.image }}
122124
imagePullPolicy: {{ .Values.imagePullPolicy }}

deploy/kubernetes/helm/values.yaml.template

+3-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ jobReplicas: 1
3939
# amount of memory to provide for API server
4040
apiServerMemory: 512M
4141
heron:
42-
url: ~
42+
# set to `-` to set base_url to the default k8s proxy URL
43+
# set to `null` to remove the use of base_url
44+
url: "-"
4345
# Topologies uploader
4446
uploader:
4547
class: dlog # s3

0 commit comments

Comments
 (0)