Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Commit c024da2

Browse files
authored
Fix snake yaml that caused unit test failures (#3506)
Fix snakeyaml caused unit test failures
1 parent f90784a commit c024da2

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ Heron is realtime analytics platform developed by Twitter. It has a wide array
2727
### Documentation
2828

2929
[https://heron.incubator.apache.org/](https://heron.incubator.apache.org/)
30+
Confluence: https://cwiki.apache.org/confluence/display/HERON
3031

3132
#### Heron Requirements:
3233
* Java 11

heron/tools/apiserver/tests/java/org/apache/heron/apiserver/utils/ConfigUtilsTests.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public void testCreateOverrides() throws IOException {
5050
final String overridesPath = ConfigUtils.createOverrideConfiguration(overrideProperties);
5151
try (Reader reader = Files.newBufferedReader(Paths.get(overridesPath))) {
5252
final Map<String, Object> overrides =
53-
(Map<String, Object>) new Yaml(new SafeConstructor()).loadAs(reader, Map.class);
53+
(Map<String, Object>) new Yaml(new SafeConstructor()).load(reader);
5454
assertEquals(overrides.size(), overrideProperties.size());
5555
for (String key : overrides.keySet()) {
5656
assertEquals(overrides.get(key), overrideProperties.getProperty(key));
@@ -82,7 +82,7 @@ public void testStateManagerFileOverrides() throws IOException {
8282

8383
try (Reader reader = Files.newBufferedReader(stateManagerPath)) {
8484
final Map<String, Object> stateManagerWithOverrides =
85-
(Map<String, Object>) new Yaml(new SafeConstructor()).loadAs(reader, Map.class);
85+
(Map<String, Object>) new Yaml(new SafeConstructor()).load(reader);
8686
assertEquals(stateManagerWithOverrides.size(), 1);
8787
assertEquals(stateManagerWithOverrides.get("heron.statemgr.connection.string"),
8888
"zookeeper:2181");
@@ -112,7 +112,7 @@ public void testNoOverridesAppliedToStateManager() throws IOException {
112112

113113
try (Reader reader = Files.newBufferedReader(stateManagerPath)) {
114114
final Map<String, Object> stateManagerWithOverrides =
115-
(Map<String, Object>) new Yaml(new SafeConstructor()).loadAs(reader, Map.class);
115+
(Map<String, Object>) new Yaml(new SafeConstructor()).load(reader);
116116
assertEquals(stateManagerWithOverrides.size(), 1);
117117
assertEquals(stateManagerWithOverrides.get("heron.statemgr.connection.string"),
118118
"<host>:<port>");
@@ -143,7 +143,7 @@ public void testApplyOverrides() throws IOException {
143143

144144
try (Reader reader = Files.newBufferedReader(Paths.get(overridesPath))) {
145145
final Map<String, Object> newOverrides =
146-
(Map<String, Object>) new Yaml(new SafeConstructor()).loadAs(reader, Map.class);
146+
(Map<String, Object>) new Yaml(new SafeConstructor()).load(reader);
147147
assertEquals(newOverrides, combinedOverrides);
148148
}
149149
}
@@ -167,7 +167,7 @@ public void testApplyEmptyOverrides() throws IOException {
167167

168168
try (Reader reader = Files.newBufferedReader(Paths.get(overridesPath))) {
169169
final Map<String, Object> newOverrides =
170-
(Map<String, Object>) new Yaml(new SafeConstructor()).loadAs(reader, Map.class);
170+
(Map<String, Object>) new Yaml(new SafeConstructor()).load(reader);
171171
assertEquals(newOverrides, overrides);
172172
}
173173
}

0 commit comments

Comments
 (0)