Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Commit 83b8226

Browse files
authored
Fixes to heron-ui arg name changes (#3634)
1 parent 5bde52f commit 83b8226

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

deploy/kubernetes/general/tools.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ spec:
7777
- >-
7878
heron-ui
7979
--port=8889
80-
--base_url=/api/v1/namespaces/default/services/heron-ui:8889/proxy
80+
--base-url=/api/v1/namespaces/default/services/heron-ui:8889/proxy
8181
resources:
8282
requests:
8383
cpu: "100m"

deploy/kubernetes/helm/templates/tools.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ spec:
117117
heron-ui
118118
--port=8889
119119
{{- if not (kindIs "invalid" .Values.heron.url) }}
120-
--base_url={{ eq .Values.heron.url "-" | ternary $defaultUrl .Values.heron.url }}
120+
--base-url={{ eq .Values.heron.url "-" | ternary $defaultUrl .Values.heron.url }}
121121
{{- end }}
122122
- name: heron-apiserver
123123
image: {{ .Values.image }}

deploy/kubernetes/helm/values.yaml.template

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobReplicas: 1
3939
# amount of memory to provide for API server
4040
apiServerMemory: 512M
4141
heron:
42-
# set to `-` to set base_url to the default k8s proxy URL
42+
# set to `-` to set base-url to the default k8s proxy URL
4343
# set to `null` to remove the use of base_url
4444
url: "-"
4545
# Topologies uploader

deploy/kubernetes/minikube/tools.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ spec:
6363
- >-
6464
heron-ui
6565
--port=8889
66-
--base_url=/api/v1/namespaces/default/services/heron-ui:8889/proxy
66+
--base-url=/api/v1/namespaces/default/services/heron-ui:8889/proxy
6767
resources:
6868
requests:
6969
cpu: "100m"

website2/docs/user-manuals-heron-ui.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,13 @@ $ ./bazel-bin/heron/tools/ui/src/python/heron-ui
4949
### Heron UI Args
5050

5151
* `--port` - Port to run the heron-ui on. Default port is `8889`.
52-
* `--tracker_url` - The base url for tracker. All the information about the
52+
* `--tracker-url` - The base url for tracker. All the information about the
5353
topologies is fetched from tracker. Default url is `http://localhost:8888`.
5454
* `--address` - Address to listen; Default address is `0.0.0.0`
55-
* `--base_url` - The base url path if operating behind proxy; Default is [`None`](https://github.com/apache/incubator-heron/blob/master/heron/tools/ui/src/python/main.py#L145)
55+
* `--base-url` - The base url path if operating behind proxy; Default is [`None`](https://github.com/apache/incubator-heron/blob/master/heron/tools/ui/src/python/main.py#L145)
5656

5757
```bash
5858
$ heron-ui
5959
# is equivalent to
60-
$ heron-ui --port=8889 --tracker_url=http://localhost:8888
60+
$ heron-ui --port=8889 --tracker-url=http://localhost:8888
6161
```

website2/website/versioned_docs/version-0.20.0-incubating/user-manuals-heron-ui.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@ $ ./bazel-bin/heron/tools/ui/src/python/heron-ui
5050
### Heron UI Args
5151

5252
* `--port` - Port to run the heron-ui on. Default port is `8889`.
53-
* `--tracker_url` - The base url for tracker. All the information about the
53+
* `--tracker-url` - The base url for tracker. All the information about the
5454
topologies is fetched from tracker. Default url is `http://localhost:8888`.
5555
* `--address` - Address to listen; Default address is `0.0.0.0`
56-
* `--base_url` - The base url path if operating behind proxy; Default is [`None`](https://github.com/apache/incubator-heron/blob/master/heron/tools/ui/src/python/main.py#L145)
56+
* `--base-url` - The base url path if operating behind proxy; Default is [`None`](https://github.com/apache/incubator-heron/blob/master/heron/tools/ui/src/python/main.py#L145)
5757

5858
```bash
5959
$ heron-ui
6060
# is equivalent to
61-
$ heron-ui --port=8889 --tracker_url=http://localhost:8888
61+
$ heron-ui --port=8889 --tracker-url=http://localhost:8888
6262
```

0 commit comments

Comments
 (0)