Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Commit 270f77e

Browse files
authored
Fix service url in Helm chart (#3534)
The template string in the values.yaml wasn't rendered, so this patch renders the default value in the template
1 parent b16853b commit 270f77e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

deploy/kubernetes/helm/templates/tools.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
{{- $platform := .Values.platform -}}
1919
{{- $jobReplicas := .Values.jobReplicas -}}
20+
{{- $defaultUrl := (printf "/api/v1/namespaces/%s/services/%s-ui:8889/proxy" .Release.Namespace .Release.Name) -}}
2021
{{- $apiServerMemory := .Values.apiServerMemory }}
2122

2223
apiVersion: v1
@@ -115,7 +116,7 @@ spec:
115116
- >-
116117
heron-ui
117118
--port=8889
118-
--base_url={{ .Values.heron.url }}
119+
--base_url={{ $defaultUrl }}
119120
- name: heron-apiserver
120121
image: {{ .Values.image }}
121122
imagePullPolicy: {{ .Values.imagePullPolicy }}

deploy/kubernetes/helm/values.yaml.template

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobReplicas: 1
3939
# amount of memory to provide for API server
4040
apiServerMemory: 512M
4141
heron:
42-
url: /api/v1/namespaces/{{ .Release.Namespace }}/services/{{ .Release.Name }}-ui:8889/proxy
42+
url: ~
4343
# Topologies uploader
4444
uploader:
4545
class: dlog # s3

0 commit comments

Comments
 (0)