more fixes

Author: elijahbenizzy

examples/materialization/run.py

@@ -2,13 +2,17 @@
 Example script showing how one might setup a generic model training pipeline that is quickly configurable.
 """
 
+import importlib
+
 # Required import to register adapters
 import data_loaders
 import model_training
 
 from hamilton import base, driver
 from hamilton.io.materialization import to
 
+importlib.import_module("custom_materializers")
+
 
 def get_model_config(model_type: str) -> dict:
     """Returns model type specific configuration"""
@@ -71,5 +75,5 @@ def get_model_config(model_type: str) -> dict:
         *materializers,
         additional_vars=["classification_report"],
     )
-    print(materialization_results["classification_report"])
-    print(additional_vars)
+    # print(materialization_results["classification_report"])
+    # print(additional_vars)

hamilton/driver.py

@@ -997,9 +997,9 @@ def materialize(
     def visualize_materialization(
         self,
         *materializers: materialization.MaterializerFactory,
-        additional_vars: List[Union[str, Callable, Variable]],
         output_file_path: str,
         render_kwargs: dict,
+        additional_vars: List[Union[str, Callable, Variable]] = None,
         inputs: Dict[str, Any] = None,
         graphviz_kwargs: dict = None,
     ) -> Optional["graphviz.Digraph"]:  # noqa F821
@@ -1014,11 +1014,13 @@ def visualize_materialization(
         :param graphviz_kwargs: Arguments to pass to graphviz
         :return: The graphviz graph, if you want to do something with it
         """
+        if additional_vars is None:
+            additional_vars = []
         function_graph = materialization.modify_graph(self.graph, materializers)
         _final_vars = self._create_final_vars(additional_vars) + [
             materializer.id for materializer in materializers
         ]
-        Driver._visualize_execution_helper(
+        return Driver._visualize_execution_helper(
             function_graph,
             self.adapter,
             _final_vars,

hamilton/graph.py

@@ -63,8 +63,10 @@ def add_dependency(
         required_node = node.Node(param_name, param_type, node_source=node.NodeType.EXTERNAL)
         nodes[param_name] = required_node
     # add edges
-    func_node.dependencies.append(required_node)
-    required_node.depended_on_by.append(func_node)
+    if required_node not in func_node.dependencies:
+        func_node.dependencies.append(required_node)
+    if func_node not in required_node.depended_on_by:
+        required_node.depended_on_by.append(func_node)
 
 
 def update_dependencies(