Skip to content

Commit 82c7c02

Browse files
committed
comment suggestions
1 parent 3a1a2eb commit 82c7c02

File tree

2 files changed

+35
-4
lines changed

2 files changed

+35
-4
lines changed

hadoop-tools/hadoop-azure/dev-support/testrun-scripts/config_support.sh

+20-3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,21 @@
22

33
set -eo pipefail
44

5+
# Licensed to the Apache Software Foundation (ASF) under one or more
6+
# contributor license agreements. See the NOTICE file distributed with
7+
# this work for additional information regarding copyright ownership.
8+
# The ASF licenses this file to You under the Apache License, Version 2.0
9+
# (the "License"); you may not use this file except in compliance with
10+
# the License. You may obtain a copy of the License at
11+
#
12+
# http://www.apache.org/licenses/LICENSE-2.0
13+
#
14+
# Unless required by applicable law or agreed to in writing, software
15+
# distributed under the License is distributed on an "AS IS" BASIS,
16+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
17+
# See the License for the specific language governing permissions and
18+
# limitations under the License.
19+
520
FILE=$1
621

722
if [ ! -f "$FILE" ]; then
@@ -19,8 +34,8 @@ cp "$FILE" "$OUTPUT_FILE"
1934

2035
contactTeamMsg="For any queries or support, kindly reach out to us at '[email protected]'."
2136
endpoint=".dfs."
22-
printf "Select 'HNS' if you're migrating to ABFS driver with Hierarchical Namespace enabled account,
23-
or 'Non-HNS' if you're migrating with Non-Hierarchical Namespace (FNS) account. \n"
37+
printf "Select 'HNS' if you're migrating to ABFS driver for Hierarchical Namespace enabled account,
38+
or 'Non-HNS' if you're migrating to ABFS driver for Non-Hierarchical Namespace (FNS) account. \n"
2439
printf "WARNING: Please ensure the correct option is chosen as it will affect the configuration changes made to the file. \n"
2540
printf "If you are unsure, follow the instructions below to check from Azure Portal: \n"
2641
printf "* Go to the Azure Portal and navigate to your storage account. \n"
@@ -88,17 +103,19 @@ obsolete_configs_list=(
88103
"storage.client.logging" #fs.azure.storage.client.logging
89104
"storage.emulator.account.name" #fs.azure.storage.emulator.account.name
90105
"storage.timeout" #fs.azure.storage.timeout
106+
"enable.append.support" #fs.azure.enable.append.support
91107
)
92108

93109
# Stop the script if any unsupported config is found
94110
for key in "${unsupported_configs_list[@]}"; do
95111
if grep -q "$key" "$OUTPUT_FILE"; then
96-
echo "FAILURE: Remove the following configuration from file and rerun: '$key'"
112+
echo "Remove the following configuration from file and rerun: '$key'"
97113
failure=true
98114
fi
99115
done
100116

101117
if [ "$failure" = true ]; then
118+
echo "FAILURE: Unsupported Config Found"
102119
echo "$contactTeamMsg"
103120
echo "Exiting..."
104121
exit 1

hadoop-tools/hadoop-azure/src/site/markdown/wasbToAbfsMigration.md

+15-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
1-
# WASB to ABFS Configuration Conversion Script
1+
<!---
2+
Licensed under the Apache License, Version 2.0 (the "License");
3+
you may not use this file except in compliance with the License.
4+
You may obtain a copy of the License at
5+
6+
http://www.apache.org/licenses/LICENSE-2.0
7+
8+
Unless required by applicable law or agreed to in writing, software
9+
distributed under the License is distributed on an "AS IS" BASIS,
10+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
11+
See the License for the specific language governing permissions and
12+
limitations under the License. See accompanying LICENSE file.
13+
-->
14+
15+
# WASB to ABFS Configuration Conversion Script
216

317
To support customer onboard for migration from WASB to ABFS driver, we've
418
introduced a script to help with the configuration changes required

0 commit comments

Comments
 (0)