Skip to content

fix leak #51843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix leak #51843

wants to merge 1 commit into from

Conversation

eldenmoon
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34489 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eded95eea59dcfdae22a33ba672dd38d88f88f18, data reload: false

------ Round 1 ----------------------------------
q1	17621	5210	5002	5002
q2	1939	277	166	166
q3	10340	1210	768	768
q4	10254	1020	529	529
q5	7886	2341	2267	2267
q6	184	159	130	130
q7	889	746	612	612
q8	9310	1257	1154	1154
q9	6806	5082	5034	5034
q10	6900	2352	1950	1950
q11	491	277	259	259
q12	337	356	212	212
q13	17766	3735	3095	3095
q14	220	221	209	209
q15	548	475	479	475
q16	424	435	370	370
q17	582	840	365	365
q18	7476	7168	7101	7101
q19	2301	991	571	571
q20	339	350	238	238
q21	4239	3311	3022	3022
q22	1059	1031	960	960
Total cold run time: 107911 ms
Total hot run time: 34489 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5146	5008	4975	4975
q2	243	317	217	217
q3	2194	2681	2258	2258
q4	1358	1802	1349	1349
q5	4208	4155	4360	4155
q6	223	183	136	136
q7	1999	1933	1802	1802
q8	2586	2598	2506	2506
q9	7248	7148	7187	7148
q10	3068	3194	2750	2750
q11	578	541	484	484
q12	673	793	615	615
q13	3478	3858	3344	3344
q14	299	299	273	273
q15	516	496	483	483
q16	440	497	431	431
q17	1141	1543	1359	1359
q18	7723	7609	7435	7435
q19	786	767	873	767
q20	1977	2063	1880	1880
q21	5004	4431	4352	4352
q22	1096	1051	1010	1010
Total cold run time: 51984 ms
Total hot run time: 49729 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192771 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eded95eea59dcfdae22a33ba672dd38d88f88f18, data reload: false

query1	1389	1041	997	997
query2	6106	1863	1799	1799
query3	11012	4494	4506	4494
query4	54397	25262	23512	23512
query5	5213	527	459	459
query6	345	256	215	215
query7	4916	527	291	291
query8	277	241	214	214
query9	5635	2634	2661	2634
query10	439	341	308	308
query11	15051	15048	14857	14857
query12	160	109	109	109
query13	1061	535	408	408
query14	10203	6485	6374	6374
query15	201	202	183	183
query16	7151	652	508	508
query17	1060	714	574	574
query18	1586	414	318	318
query19	204	201	166	166
query20	127	133	120	120
query21	206	129	111	111
query22	4410	4303	4243	4243
query23	34518	33465	33601	33465
query24	6518	2429	2449	2429
query25	476	510	422	422
query26	687	275	153	153
query27	2178	509	354	354
query28	3330	2150	2131	2131
query29	602	580	421	421
query30	270	227	200	200
query31	867	871	792	792
query32	70	64	62	62
query33	462	352	344	344
query34	813	869	514	514
query35	789	830	768	768
query36	923	978	903	903
query37	121	108	80	80
query38	4269	4344	4345	4344
query39	1505	1494	1466	1466
query40	219	129	110	110
query41	60	58	66	58
query42	130	112	109	109
query43	492	519	476	476
query44	1307	845	873	845
query45	181	182	174	174
query46	867	1033	634	634
query47	1817	1881	1814	1814
query48	404	454	318	318
query49	663	511	406	406
query50	660	704	407	407
query51	4307	4261	4205	4205
query52	130	107	109	107
query53	246	252	193	193
query54	585	574	513	513
query55	87	86	85	85
query56	295	307	294	294
query57	1191	1279	1164	1164
query58	264	274	265	265
query59	2767	2798	2854	2798
query60	333	341	318	318
query61	129	120	128	120
query62	763	735	678	678
query63	226	199	190	190
query64	1471	1013	659	659
query65	4234	4174	4158	4158
query66	731	394	312	312
query67	15981	15539	15425	15425
query68	6199	883	521	521
query69	532	308	269	269
query70	1177	1073	1067	1067
query71	496	322	297	297
query72	5895	4831	4664	4664
query73	1286	586	365	365
query74	9028	9183	8677	8677
query75	3294	3187	2695	2695
query76	3809	1187	762	762
query77	557	360	292	292
query78	10080	10172	9427	9427
query79	2064	797	586	586
query80	749	506	440	440
query81	479	274	224	224
query82	204	125	95	95
query83	247	255	238	238
query84	299	108	83	83
query85	744	344	314	314
query86	354	298	267	267
query87	4383	4430	4438	4430
query88	3280	2318	2277	2277
query89	381	308	282	282
query90	1783	196	222	196
query91	142	144	112	112
query92	74	59	64	59
query93	2228	926	576	576
query94	686	389	317	317
query95	370	289	286	286
query96	494	569	280	280
query97	2655	2770	2653	2653
query98	236	209	201	201
query99	1333	1418	1242	1242
Total cold run time: 295625 ms
Total hot run time: 192771 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.78 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eded95eea59dcfdae22a33ba672dd38d88f88f18, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.07
query4	1.61	0.11	0.11
query5	0.42	0.42	0.41
query6	1.15	0.66	0.65
query7	0.02	0.02	0.02
query8	0.05	0.03	0.04
query9	0.58	0.53	0.52
query10	0.58	0.57	0.58
query11	0.15	0.10	0.12
query12	0.15	0.12	0.12
query13	0.62	0.62	0.60
query14	0.82	0.81	0.81
query15	0.89	0.87	0.87
query16	0.39	0.39	0.40
query17	1.04	1.09	1.07
query18	0.23	0.22	0.21
query19	1.93	1.88	1.85
query20	0.02	0.01	0.01
query21	15.39	0.91	0.53
query22	0.74	1.01	0.70
query23	15.09	1.36	0.62
query24	7.23	1.15	0.98
query25	0.51	0.27	0.09
query26	0.63	0.16	0.13
query27	0.06	0.06	0.05
query28	9.89	0.89	0.46
query29	12.59	3.98	3.30
query30	0.26	0.09	0.08
query31	2.82	0.60	0.40
query32	3.22	0.55	0.46
query33	3.09	3.11	3.10
query34	16.09	5.41	4.78
query35	4.84	4.81	4.82
query36	0.69	0.50	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.18	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 104.62 s
Total hot run time: 29.78 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.34% (15050/26713)
Line Coverage 45.11% (134594/298376)
Region Coverage 44.24% (67686/152984)
Branch Coverage 38.83% (34733/89440)

@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33846 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 125ce7e72e6dc889a037a573959e37b6afb1319f, data reload: false

------ Round 1 ----------------------------------
q1	17586	5224	5035	5035
q2	1940	297	187	187
q3	10289	1243	757	757
q4	10233	1002	523	523
q5	7695	2387	2277	2277
q6	181	158	132	132
q7	894	746	612	612
q8	9308	1294	1104	1104
q9	6694	5034	5091	5034
q10	6947	2387	1945	1945
q11	484	283	278	278
q12	343	353	213	213
q13	17770	3666	3098	3098
q14	228	228	218	218
q15	572	481	477	477
q16	434	430	371	371
q17	596	852	360	360
q18	7563	7255	7065	7065
q19	1593	957	567	567
q20	323	343	227	227
q21	3741	3086	2389	2389
q22	1037	1023	977	977
Total cold run time: 106451 ms
Total hot run time: 33846 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5135	5113	5095	5095
q2	240	322	227	227
q3	2185	2649	2355	2355
q4	1345	1788	1339	1339
q5	4189	4124	4307	4124
q6	209	172	130	130
q7	2029	1959	1770	1770
q8	2605	2503	2473	2473
q9	7215	7124	7168	7124
q10	3107	3233	2794	2794
q11	592	523	513	513
q12	681	810	650	650
q13	3552	3878	3291	3291
q14	281	294	275	275
q15	558	483	483	483
q16	446	504	447	447
q17	1157	1474	1388	1388
q18	7659	7425	7597	7425
q19	806	886	1014	886
q20	1996	2099	1913	1913
q21	4874	4438	4396	4396
q22	1072	1079	1054	1054
Total cold run time: 51933 ms
Total hot run time: 50152 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.33% (15048/26712)
Line Coverage 45.10% (134580/298372)
Region Coverage 44.24% (67686/152982)
Branch Coverage 38.82% (34719/89440)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.01% (16040/26289)
Line Coverage 50.54% (150722/298214)
Region Coverage 47.85% (86105/179951)
Branch Coverage 41.39% (42315/102244)

2 similar comments
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.01% (16040/26289)
Line Coverage 50.54% (150722/298214)
Region Coverage 47.85% (86105/179951)
Branch Coverage 41.39% (42315/102244)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.01% (16040/26289)
Line Coverage 50.54% (150722/298214)
Region Coverage 47.85% (86105/179951)
Branch Coverage 41.39% (42315/102244)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants