-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[feat](jdbc) support custom function rules in catalog properties #51471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
morningman
wants to merge
10
commits into
apache:master
Choose a base branch
from
morningman:custome_pushdown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,564
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run buildall |
TPC-H: Total hot run time: 33856 ms
|
TPC-DS: Total hot run time: 188523 ms
|
ClickBench: Total hot run time: 29.46 s
|
run buildall |
This was referenced Jun 6, 2025
run buildall |
TPC-H: Total hot run time: 33963 ms
|
TPC-DS: Total hot run time: 193058 ms
|
ClickBench: Total hot run time: 29.16 s
|
ddc3281
to
34c78f1
Compare
run buildall |
TPC-H: Total hot run time: 33633 ms
|
TPC-DS: Total hot run time: 192566 ms
|
ClickBench: Total hot run time: 29.17 s
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add new jdbc catalog property:
function_rules
.This property will enable user to customize which function can be pushed down to jdbc datasource,
and which function should be rewrote to function in jdbc datasource:
eg:
The value is a json format config:
pushdown
: the value ofpushdown
is a map, thesupported
array indicate the function that can be pushed down to datasource. theunsupported
array indicate the function that can not.rewrite
: the value ofrewrite
is map, if the function can be pushed down to datasource, it will be renamed to the value in rewrite map.eg:
will generate sql:
You can see the
abs()
is not pushed down, andto_date()
is rewrote todate2()
.This change is compatible with previous version.
Previously, there are some hard coded function rules, and also a FE config
jdbc_mysql_unsupported_pushdown_functions
.Doris will merge the user specified
function_rules
and the above rules.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)