[fix](iceberg) fix the iceberg timstamp_ntz write schema and values bug. #51384
+100
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
ghkang98
force-pushed
the
iceberg-timestamp-ntz
branch
from
546e823 to
aaad9d4
Compare
|
run buildall |
TPC-H: Total hot run time: 33643 ms |
TPC-DS: Total hot run time: 193001 ms |
ClickBench: Total hot run time: 28.56 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
reviewed
Jun 1, 2025
| @@ -70,7 +70,9 @@ Status ArrowSchemaUtil::convert_to(const iceberg::NestedField& field, | |||
| break; | |||
|
|
|||
| case iceberg::TypeID::TIMESTAMP: { | |||
| arrow_type = std::make_shared<arrow::TimestampType>(arrow::TimeUnit::MICRO, timezone); | |||
| iceberg::TimestampType* t_type = static_cast<iceberg::TimestampType*>(field.field_type()); | |||
There was a problem hiding this comment.
Please add regression test cases
There was a problem hiding this comment.
Integration test case has been added
|
run buildall |
TPC-H: Total hot run time: 34461 ms |
TPC-DS: Total hot run time: 185734 ms |
ClickBench: Total hot run time: 29.33 s |
|
run buildall |
TPC-H: Total hot run time: 33998 ms |
TPC-DS: Total hot run time: 185846 ms |
ClickBench: Total hot run time: 28.76 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
ghkang98
force-pushed
the
iceberg-timestamp-ntz
branch
3 times, most recently
from
a95e906 to
26d24b9
Compare
TPC-H: Total hot run time: 34130 ms |
TPC-DS: Total hot run time: 192455 ms |
ClickBench: Total hot run time: 29.41 s |
ghkang98
force-pushed
the
iceberg-timestamp-ntz
branch
from
26d24b9 to
6ef3ab8
Compare
|
run buildall |
TPC-H: Total hot run time: 33809 ms |
TPC-DS: Total hot run time: 186511 ms |
ClickBench: Total hot run time: 29.41 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33811 ms |
TPC-DS: Total hot run time: 186435 ms |
ClickBench: Total hot run time: 29.03 s |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR is mainly to fix the time zone issue of doris writing in Iceberg in the data lake scenario. In Iceberg, there are two time zone types: timestamp_ltz and timestamp_ntz. Currently, there is no distinction between these two scenarios for doris, resulting in different spark query results for data written by doris under the timestamp_ntz type. This PR is to solve this problem.
Check List (For Author)
Manual test and The test report is as follows：
Doris-iceberg-timestampntz-test-report.pdf
Behavior changed:
No.
Does this need documentation?
No.