-
Notifications
You must be signed in to change notification settings - Fork 426
Local method/properties can be accessed by other classes #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I tried to fix this issue with my branch and I made sure to resolve issue. If there are no problems, I would like to make PR. |
I'm not so sure if this a good idea. I would definitely be supportive of making these methods private if this was a new package but giving that this is a really old plugin that's always had public members, there could be systems that depends on these. A third-party plugin (or even native workflow app) could fetch the plugin instance from While that definitely wouldn't be a common practice, I'm not sure if value of making these methods/properties private for proper encapsulation outweighs the risk of breaking third-party code that may depend on the public API. |
I don't have certain answer for that. And I doubt that it's worth to change accessibility RIGHT NOW. So, how about add deprecated annotation and explanations to public methods? |
That might be the best path forward, since it will be easy to remove the deprecation if we happen to get push-back later. We can revisit this when preparing a major release. |
Plugins can add other plugins as dependencies, and subclass or use existing methods from the other plugins, this would break that use case. |
I agree generally. But there is the comment And also I think there are no contradictions when the reason for |
Feature Request
Motivation Behind Feature
On Android implementation, local methods and properties are defined as public. But I don't think these are expected to call by other methods.
Feature Description
execute()
accessibility from public to private.uuid
accessibility from public to private.Alternatives or Workarounds
N/A
The text was updated successfully, but these errors were encountered: