Skip to content

Commit 4c9dc10

Browse files
authored
deprecation: allowEdit (#914)
* deprecation: allowEdit * applied suggestions to verbiage
1 parent de468b6 commit 4c9dc10

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ Optional parameters to customize the camera settings.
307307
| quality | <code>number</code> | <code>50</code> | Quality of the saved image, expressed as a range of 0-100, where 100 is typically full resolution with no loss from file compression. (Note that information about the camera's resolution is unavailable.) |
308308
| destinationType | <code>[DestinationType](#module_Camera.DestinationType)</code> | <code>FILE_URI</code> | Choose the format of the return value. |
309309
| sourceType | <code>[PictureSourceType](#module_Camera.PictureSourceType)</code> | <code>CAMERA</code> | Set the source of the picture. |
310-
| allowEdit | <code>Boolean</code> | <code>false</code> | Allow simple editing of image before selection. |
310+
| ~~allowEdit~~ | <code>Boolean</code> | <code>false</code> | **Deprecated**. Allow simple editing of image before selection. |
311311
| encodingType | <code>[EncodingType](#module_Camera.EncodingType)</code> | <code>JPEG</code> | Choose the returned image file's encoding. |
312312
| targetWidth | <code>number</code> | | Width in pixels to scale image. Must be used with `targetHeight`. Aspect ratio remains constant. |
313313
| targetHeight | <code>number</code> | | Height in pixels to scale image. Must be used with `targetWidth`. Aspect ratio remains constant. |

www/Camera.js

+4
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,10 @@ cameraExport.getPicture = function (successCallback, errorCallback, options) {
143143
const popoverOptions = getValue(options.popoverOptions, null);
144144
const cameraDirection = getValue(options.cameraDirection, Camera.Direction.BACK);
145145

146+
if (allowEdit) {
147+
console.warn('allowEdit is deprecated. It does not work reliably on all platforms. Utilise a dedicated image editing library instead. allowEdit functionality is scheduled to be removed in a future release.');
148+
}
149+
146150
const args = [quality, destinationType, sourceType, targetWidth, targetHeight, encodingType,
147151
mediaType, allowEdit, correctOrientation, saveToPhotoAlbum, popoverOptions, cameraDirection];
148152

0 commit comments

Comments
 (0)