eslint: fix missing eslint dependencies and lint errors (#19)

Fixes: #17
Fixes: #18

These dependencies are necessary or eslint will fail with the standard vue.js rule set.
The PR also includes fixes for all lint errors.

Signed-off-by: Rohit Yadav <[email protected]>

Author: onitake

ui/package-lock.json

@@ -67,7 +67,7 @@
     "@vue/cli-plugin-eslint": "^4.0.5",
     "@vue/cli-plugin-unit-jest": "^4.0.5",
     "@vue/cli-service": "^4.0.5",
-    "@vue/eslint-config-standard": "^4.0.0",
+    "@vue/eslint-config-standard": "^5.0.0",
     "@vue/test-utils": "^1.0.0-beta.20",
     "babel-core": "7.0.0-bridge.0",
     "babel-eslint": "^10.0.3",
@@ -76,6 +76,10 @@
     "eslint": "^6.6.0",
     "eslint-plugin-html": "^6.0.0",
     "eslint-plugin-vue": "^6.0.1",
+    "eslint-plugin-import": "^2.18.2",
+    "eslint-plugin-node": "^10.0.0",
+    "eslint-plugin-promise": "^4.2.1",
+    "eslint-plugin-standard": "^4.0.1",
     "less": "^3.10.3",
     "less-loader": "^5.0.0",
     "vue-cli-plugin-i18n": "^0.6.0",

ui/package.json

@@ -18,8 +18,8 @@
 import { axios } from '@/utils/request'
 
 export function api (command, args = {}) {
-  args['command'] = command
-  args['response'] = 'json'
+  args.command = command
+  args.response = 'json'
   return axios.get('/', {
     params: args
   })

ui/src/api/index.js

@@ -61,9 +61,9 @@ export default {
       jobs: [],
       poller: null,
       notificationAvatar: {
-        'done': { 'icon': 'check-circle', 'style': 'backgroundColor:#87d068' },
-        'progress': { 'icon': 'loading', 'style': 'backgroundColor:#ffbf00' },
-        'failed': { 'icon': 'close-circle', 'style': 'backgroundColor:#f56a00' }
+        done: { icon: 'check-circle', style: 'backgroundColor:#87d068' },
+        progress: { icon: 'loading', style: 'backgroundColor:#ffbf00' },
+        failed: { icon: 'close-circle', style: 'backgroundColor:#f56a00' }
       }
     }
   },
@@ -85,11 +85,11 @@ export default {
       var hasUpdated = false
       for (var i in this.jobs) {
         if (this.jobs[i].status === 'progress') {
-          await api('queryAsyncJobResult', { 'jobid': this.jobs[i].jobid }).then(json => {
+          await api('queryAsyncJobResult', { jobid: this.jobs[i].jobid }).then(json => {
             var result = json.queryasyncjobresultresponse
             if (result.jobstatus === 1 && this.jobs[i].status !== 'done') {
               hasUpdated = true
-              this.$notification['success']({
+              this.$notification.success({
                 message: this.jobs[i].title,
                 description: this.jobs[i].description
               })
@@ -100,7 +100,7 @@ export default {
               if (result.jobresult.errortext !== null) {
                 this.jobs[i].description = '(' + this.jobs[i].description + ') ' + result.jobresult.errortext
               }
-              this.$notification['error']({
+              this.$notification.error({
                 message: this.jobs[i].title,
                 description: this.jobs[i].description
               })

ui/src/components/header/HeaderNotice.vue

@@ -84,7 +84,7 @@ export default {
       getNextPage()
     },
     isDisabled () {
-      return !store.getters.apis.hasOwnProperty('listProjects')
+      return !Object.prototype.hasOwnProperty.call(store.getters.apis, 'listProjects')
     },
     setSelectedProject (project) {
       this.selectedProject = project.displaytext || project.name

ui/src/components/header/ProjectMenu.vue

@@ -150,7 +150,7 @@ export default {
     }
   },
   watch: {
-    '$route': function (newVal) {
+    $route: function (newVal) {
       this.activeKey = newVal.fullPath
       if (this.fullPathList.indexOf(newVal.fullPath) < 0) {
         this.fullPathList.push(newVal.fullPath)

ui/src/components/multitab/MultiTab.vue

@@ -496,7 +496,7 @@ export default {
         return
       }
       this.tags = []
-      api('listTags', { 'listall': true, 'resourceid': this.resource.id, 'resourcetype': this.resourceType }).then(json => {
+      api('listTags', { listall: true, resourceid: this.resource.id, resourcetype: this.resourceType }).then(json => {
         if (json.listtagsresponse && json.listtagsresponse.tag) {
           this.tags = json.listtagsresponse.tag
         }
@@ -507,7 +507,7 @@ export default {
         return
       }
       this.notes = []
-      api('listAnnotations', { 'entityid': this.resource.id, 'entitytype': this.annotationType }).then(json => {
+      api('listAnnotations', { entityid: this.resource.id, entitytype: this.annotationType }).then(json => {
         if (json.listannotationsresponse && json.listannotationsresponse.annotation) {
           this.notes = json.listannotationsresponse.annotation
         }
@@ -527,8 +527,8 @@ export default {
     },
     handleInputConfirm () {
       const args = {}
-      args['resourceids'] = this.resource.id
-      args['resourcetype'] = this.resourceType
+      args.resourceids = this.resource.id
+      args.resourcetype = this.resourceType
       args['tags[0].key'] = this.inputKey
       args['tags[0].value'] = this.inputValue
       api('createTags', args).then(json => {
@@ -542,8 +542,8 @@ export default {
     },
     handleDeleteTag (tag) {
       const args = {}
-      args['resourceids'] = tag.resourceid
-      args['resourcetype'] = tag.resourcetype
+      args.resourceids = tag.resourceid
+      args.resourcetype = tag.resourcetype
       args['tags[0].key'] = tag.key
       args['tags[0].value'] = tag.value
       api('deleteTags', args).then(json => {
@@ -560,9 +560,9 @@ export default {
       }
       this.showNotesInput = false
       const args = {}
-      args['entityid'] = this.resource.id
-      args['entitytype'] = this.annotationType
-      args['annotation'] = this.annotation
+      args.entityid = this.resource.id
+      args.entitytype = this.annotationType
+      args.annotation = this.annotation
       api('addAnnotation', args).then(json => {
       }).finally(e => {
         this.getNotes()
@@ -571,7 +571,7 @@ export default {
     },
     deleteNote (annotation) {
       const args = {}
-      args['id'] = annotation.id
+      args.id = annotation.id
       api('removeAnnotation', args).then(json => {
       }).finally(e => {
         this.getNotes()

ui/src/components/view/InfoCard.vue

@@ -76,7 +76,7 @@ export default {
         return
       }
       this.name = 'linux'
-      api('listOsTypes', { 'id': osId }).then(json => {
+      api('listOsTypes', { id: osId }).then(json => {
         if (json && json.listostypesresponse && json.listostypesresponse.ostype && json.listostypesresponse.ostype.length > 0) {
           this.discoverOsLogo(json.listostypesresponse.ostype[0].description)
         } else {

ui/src/components/widgets/OsLogo.vue

@@ -96,7 +96,7 @@ export function generateRouterMap (section) {
               title: child.title,
               name: child.name,
               keepAlive: true,
-              permission: [ action.api ]
+              permission: [action.api]
             },
             component: action.component,
             hidden: true

ui/src/config/router.js

@@ -24,11 +24,12 @@ export default {
       name: 'vm',
       title: 'Instances',
       icon: 'desktop',
-      permission: [ 'listVirtualMachinesMetrics', 'listVirtualMachines' ],
+      permission: ['listVirtualMachinesMetrics', 'listVirtualMachines'],
       resourceType: 'UserVm',
       columns: [
         'name', 'state', 'instancename', 'ipaddress', 'cpunumber', 'cpuused', 'cputotal',
-        { 'memoryused':
+        {
+          memoryused:
           (record) => {
             return record.memorykbs && record.memoryintfreekbs ? parseFloat(100.0 * (record.memorykbs - record.memoryintfreekbs) / record.memorykbs).toFixed(2) + '%' : '0.0%'
           }
@@ -230,7 +231,7 @@ export default {
       name: 'ssh',
       title: 'SSH Key Pairs',
       icon: 'key',
-      permission: [ 'listSSHKeyPairs' ],
+      permission: ['listSSHKeyPairs'],
       columns: ['name', 'fingerprint', 'account', 'domain'],
       details: ['name', 'fingerprint', 'account', 'domain'],
       actions: [
@@ -261,7 +262,7 @@ export default {
       name: 'affinitygroup',
       title: 'Affinity Groups',
       icon: 'swap',
-      permission: [ 'listAffinityGroups' ],
+      permission: ['listAffinityGroups'],
       columns: ['name', 'type', 'description', 'account', 'domain'],
       details: ['name', 'id', 'description', 'type', 'account', 'domain'],
       actions: [

ui/src/config/section/compute.js

@@ -19,22 +19,22 @@ export default {
   name: 'config',
   title: 'Configuration',
   icon: 'setting',
-  permission: [ 'listConfigurations' ],
+  permission: ['listConfigurations'],
   children: [
     {
       name: 'globalsetting',
       title: 'Global Settings',
       icon: 'setting',
-      permission: [ 'listConfigurations' ],
-      columns: [ 'name', 'description', 'category', 'value' ],
-      details: [ 'name', 'category', 'description', 'value' ]
+      permission: ['listConfigurations'],
+      columns: ['name', 'description', 'category', 'value'],
+      details: ['name', 'category', 'description', 'value']
     },
     {
       name: 'ldapsetting',
       title: 'LDAP Configuration',
       icon: 'team',
-      permission: [ 'listLdapConfigurations' ],
-      columns: [ 'hostname', 'port' ],
+      permission: ['listLdapConfigurations'],
+      columns: ['hostname', 'port'],
       actions: [
         {
           api: 'addLdapConfiguration',
@@ -51,8 +51,8 @@ export default {
       name: 'hypervisorcapability',
       title: 'Hypervisor Capabilities',
       icon: 'database',
-      permission: [ 'listHypervisorCapabilities' ],
-      columns: [ 'hypervisor', 'hypervisorversion', 'maxguestlimit', 'maxdatavolumeslimit', 'maxhostspercluster' ],
+      permission: ['listHypervisorCapabilities'],
+      columns: ['hypervisor', 'hypervisorversion', 'maxguestlimit', 'maxdatavolumeslimit', 'maxhostspercluster'],
       actions: [
         {
           api: 'updateHypervisorCapabilities',

ui/src/config/section/config.js

@@ -19,13 +19,13 @@ export default {
   name: 'iam',
   title: 'Identity and Access',
   icon: 'solution',
-  permission: [ 'listAccounts', 'listUsers', 'listDomains', 'listRoles' ],
+  permission: ['listAccounts', 'listUsers', 'listDomains', 'listRoles'],
   children: [
     {
       name: 'accountuser',
       title: 'Users',
       icon: 'user',
-      permission: [ 'listUsers' ],
+      permission: ['listUsers'],
       columns: ['username', 'state', 'firstname', 'lastname', 'email', 'account', 'domain'],
       details: ['username', 'id', 'firstname', 'lastname', 'email', 'usersource', 'timezone', 'rolename', 'roletype', 'account', 'domain', 'created'],
       actions: [
@@ -86,7 +86,7 @@ export default {
       name: 'account',
       title: 'Accounts',
       icon: 'team',
-      permission: [ 'listAccounts' ],
+      permission: ['listAccounts'],
       columns: ['name', 'state', 'firstname', 'lastname', 'rolename', 'roletype', 'domain'],
       details: ['name', 'id', 'rolename', 'roletype', 'domain', 'networkdomain', 'iptotal', 'vmtotal', 'volumetotal', 'receivedbytes', 'sentbytes', 'vmlimit', 'iplimit', 'volumelimit', 'snapshotlimit', 'templatelimit', 'vpclimit', 'cpulimit', 'memorylimit', 'networklimit', 'primarystoragelimit', 'secondarystoragelimit'],
       actions: [
@@ -118,7 +118,7 @@ export default {
           dataView: true,
           show: (record) => { return record.state === 'disabled' || record.state === 'locked' },
           args: ['id'],
-          params: { 'lock': 'false' }
+          params: { lock: 'false' }
         },
         {
           api: 'disableAccount',
@@ -127,7 +127,7 @@ export default {
           dataView: true,
           show: (record) => { return record.state === 'enabled' },
           args: ['id'],
-          params: { 'lock': 'false' }
+          params: { lock: 'false' }
         },
         {
           api: 'disableAccount',
@@ -153,7 +153,7 @@ export default {
       name: 'domain',
       title: 'Domains',
       icon: 'block',
-      permission: [ 'listDomains' ],
+      permission: ['listDomains'],
       resourceType: 'Domain',
       columns: ['name', 'state', 'path', 'parentdomainname', 'level'],
       details: ['name', 'id', 'path', 'parentdomainname', 'level', 'networkdomain', 'iptotal', 'vmtotal', 'volumetotal', 'vmlimit', 'iplimit', 'volumelimit', 'snapshotlimit', 'templatelimit', 'vpclimit', 'cpulimit', 'memorylimit', 'networklimit', 'primarystoragelimit', 'secondarystoragelimit'],
@@ -193,7 +193,7 @@ export default {
       name: 'role',
       title: 'Roles',
       icon: 'idcard',
-      permission: [ 'listRoles' ],
+      permission: ['listRoles'],
       columns: ['name', 'type', 'description'],
       details: ['name', 'id', 'type', 'description'],
       actions: [