Skip to content

Commit d39e025

Browse files
DaanHooglandDaan Hoogland
authored andcommitted
CLOUDSTACK-8073 load cidrs on create response
1 parent fc8606d commit d39e025

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

server/src/com/cloud/api/ApiDBUtils.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@
201201
import com.cloud.network.security.SecurityGroupVO;
202202
import com.cloud.network.security.dao.SecurityGroupDao;
203203
import com.cloud.network.vpc.NetworkACL;
204+
import com.cloud.network.vpc.NetworkACLItemCidrsDao;
204205
import com.cloud.network.vpc.StaticRouteVO;
205206
import com.cloud.network.vpc.VpcGatewayVO;
206207
import com.cloud.network.vpc.VpcManager;
@@ -357,6 +358,7 @@ public class ApiDBUtils {
357358
static ConfigurationDao s_configDao;
358359
static ConsoleProxyDao s_consoleProxyDao;
359360
static FirewallRulesCidrsDao s_firewallCidrsDao;
361+
static NetworkACLItemCidrsDao s_networkACLItemCidrsDao;
360362
static VMInstanceDao s_vmDao;
361363
static ResourceLimitService s_resourceLimitMgr;
362364
static ProjectService s_projectMgr;
@@ -524,6 +526,8 @@ public class ApiDBUtils {
524526
@Inject
525527
private FirewallRulesCidrsDao firewallCidrsDao;
526528
@Inject
529+
private NetworkACLItemCidrsDao networkACLItemCidrsDao;
530+
@Inject
527531
private VMInstanceDao vmDao;
528532
@Inject
529533
private ResourceLimitService resourceLimitMgr;
@@ -692,6 +696,7 @@ void init() {
692696
s_configDao = configDao;
693697
s_consoleProxyDao = consoleProxyDao;
694698
s_firewallCidrsDao = firewallCidrsDao;
699+
s_networkACLItemCidrsDao = networkACLItemCidrsDao;
695700
s_vmDao = vmDao;
696701
s_resourceLimitMgr = resourceLimitMgr;
697702
s_projectMgr = projectMgr;
@@ -1241,6 +1246,10 @@ public static List<String> findFirewallSourceCidrs(long id) {
12411246
return s_firewallCidrsDao.getSourceCidrs(id);
12421247
}
12431248

1249+
public static List<String> findNetworkAclItemSourceCidrs(long id) {
1250+
return s_networkACLItemCidrsDao.getCidrs(id);
1251+
}
1252+
12441253
public static Account getProjectOwner(long projectId) {
12451254
return s_projectMgr.getProjectOwner(projectId);
12461255
}

server/src/com/cloud/api/ApiResponseHelper.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2349,7 +2349,8 @@ public NetworkACLItemResponse createNetworkACLItemResponse(NetworkACLItem aclIte
23492349
response.setEndPort(Integer.toString(aclItem.getSourcePortEnd()));
23502350
}
23512351

2352-
response.setCidrList(StringUtils.join(aclItem.getSourceCidrList(), ","));
2352+
List<String> cidrs = ApiDBUtils.findNetworkAclItemSourceCidrs(aclItem.getId());
2353+
response.setCidrList(StringUtils.join(cidrs, ","));
23532354

23542355
response.setTrafficType(aclItem.getTrafficType().toString());
23552356

0 commit comments

Comments
 (0)