Skip to content

Commit 18d181b

Browse files
shwstpprrohityadavcloud
authored andcommitted
configuration: notify admin to restart MS for non-dynamic settings (#290)
Fixes #83 Signed-off-by: Abhishek Kumar <[email protected]> Signed-off-by: Rohit Yadav <[email protected]>
1 parent bbe01c9 commit 18d181b

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

ui/src/components/view/ListView.vue

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -266,14 +266,19 @@ export default {
266266
api('updateConfiguration', {
267267
name: record.name,
268268
value: this.editableValue
269-
}).then(() => {
269+
}).then(json => {
270270
this.editableValueKey = null
271271
272272
this.$message.success('Setting Updated: ' + record.name)
273-
this.$notification.warning({
274-
message: 'Status',
275-
description: 'Please restart your management server(s) for your new settings to take effect.'
276-
})
273+
if (json.updateconfigurationresponse &&
274+
json.updateconfigurationresponse.configuration &&
275+
!json.updateconfigurationresponse.configuration.isdynamic &&
276+
['Admin'].includes(this.$store.getters.userInfo.roletype)) {
277+
this.$notification.warning({
278+
message: 'Status',
279+
description: 'Please restart your management server(s) for your new settings to take effect.'
280+
})
281+
}
277282
}).catch(error => {
278283
console.error(error)
279284
this.$message.error('There was an error saving this setting.')

0 commit comments

Comments
 (0)