Skip to content

Commit 6697826

Browse files
authored
ARROW-18120: [Release][Dev] Automate running binaries/wheels verifications (#14469)
Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 917f70b commit 6697826

File tree

4 files changed

+48
-7
lines changed

4 files changed

+48
-7
lines changed

dev/archery/archery/crossbow/cli.py

-5
Original file line numberDiff line numberDiff line change
@@ -193,11 +193,6 @@ def verify_release_candidate(obj, base_branch, create_pr,
193193
# Redefine Arrow repo to use the correct arrow remote.
194194
arrow = Repo(path=obj['arrow'].path, remote_url=remote)
195195

196-
# Default value for base_branch is the repository's default branch name
197-
if base_branch is None:
198-
# Get the default branch name from the repository
199-
base_branch = arrow.default_branch_name
200-
201196
response = arrow.github_pr(title=pr_title, head=head_branch,
202197
base=base_branch, body=pr_body,
203198
github_token=obj['queue'].github_token,

dev/archery/archery/crossbow/core.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -572,8 +572,9 @@ def github_overwrite_release_assets(self, tag_name, target_commitish,
572572

573573
def github_pr(self, title, head=None, base=None, body=None,
574574
github_token=None, create=False):
575-
# Default value for base is the default_branch_name
576-
base = self.default_branch_name if base is None else base
575+
if create:
576+
# Default value for base is the default_branch_name
577+
base = self.default_branch_name if base is None else base
577578
github_token = github_token or self.github_token
578579
repo = self.as_github_repo(github_token=github_token)
579580
if create:

dev/release/07-binary-verify.sh

+42
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
#!/usr/bin/env bash
2+
#
3+
# Licensed to the Apache Software Foundation (ASF) under one
4+
# or more contributor license agreements. See the NOTICE file
5+
# distributed with this work for additional information
6+
# regarding copyright ownership. The ASF licenses this file
7+
# to you under the Apache License, Version 2.0 (the
8+
# "License"); you may not use this file except in compliance
9+
# with the License. You may obtain a copy of the License at
10+
#
11+
# http://www.apache.org/licenses/LICENSE-2.0
12+
#
13+
# Unless required by applicable law or agreed to in writing,
14+
# software distributed under the License is distributed on an
15+
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
16+
# KIND, either express or implied. See the License for the
17+
# specific language governing permissions and limitations
18+
# under the License.
19+
20+
set -e
21+
set -u
22+
set -o pipefail
23+
24+
if [ "$#" -ne 2 ]; then
25+
echo "Usage: $0 <version> <rc-num>"
26+
exit
27+
fi
28+
29+
version=$1
30+
rc=$2
31+
32+
rc_branch="release-${version}-rc${rc}"
33+
34+
archery crossbow \
35+
verify-release-candidate \
36+
--head-branch=${rc_branch} \
37+
--pr-title="WIP: [Release] Verify ${rc_branch}" \
38+
--rc=${rc} \
39+
--remote=https://github.com/apache/arrow \
40+
--verify-binaries \
41+
--verify-wheels \
42+
--version=${version}

docs/source/developers/release.rst

+3
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,9 @@ Build source and binaries and submit them
184184
# https://repository.apache.org/#stagingRepositories
185185
dev/release/06-java-upload.sh <version> <rc-number>
186186
187+
# Start verifications for binaries and wheels
188+
dev/release/07-binary-verify.sh <version> <rc-number>
189+
187190
Verify the Release
188191
------------------
189192

0 commit comments

Comments
 (0)