You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calling e.g. `FLOAT4.getNewVector("foo", new FieldType(false, ...), ...)" returns a NullableFloat4Vector instead of a Float4Vector.
edit: Float4Vector doesn't implement FieldVector, so can't currently be a top-level vector. I'm confused as to what the nullable flag is supposed to represent then.
Jacques Nadeau / @jacques-n:
You probably need to update the vectors so that they set all the bits to null if they have "no-nulls". The goal was to only have nullable types in the java implementation as we found maintaining two parallel sets of vectors an extra level of complexity.
Emilio Lahr-Vivaz / @elahrvivaz:
Thanks, maybe I should update this issue to be 'implement non-nullable FieldVectors'? Is that something that would be desirable to implement, or would it introduce too much complexity? It seems like it would provide a performance improvement in the non-nullable case.
Jacques Nadeau / @jacques-n:
I've previously found that it adds excessive complexity (earlier versions of Arrow maintained them more as alternatives to the nullable versions). We've generally found that once you do vectorized operations, word-wise or wider bitmap evals are rarely the performance bottleneck.
Calling e.g. `FLOAT4.getNewVector("foo", new FieldType(false, ...), ...)" returns a NullableFloat4Vector instead of a Float4Vector.
edit: Float4Vector doesn't implement FieldVector, so can't currently be a top-level vector. I'm confused as to what the nullable flag is supposed to represent then.
Reporter: Emilio Lahr-Vivaz / @elahrvivaz
Note: This issue was originally created as ARROW-999. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: