-
Notifications
You must be signed in to change notification settings - Fork 129
test(csharp/src/Drivers): add Spice.ai test target #2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sgrebnov
wants to merge
3
commits into
apache:main
Choose a base branch
from
spiceai:sgrebnov/spiceai-test-target
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+249
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
051f8ef
to
af18d6a
Compare
sgrebnov
commented
Jun 11, 2025
sgrebnov
commented
Jun 11, 2025
sgrebnov
commented
Jun 11, 2025
sgrebnov
commented
Jun 11, 2025
sgrebnov
commented
Jun 11, 2025
Shouldn't we test the driver directly instead of through C#? |
lidavidm
reviewed
Jun 11, 2025
@lidavidm - thank you for review!
Good point. The reason the test was added based on the C# interop driver is to cover both:
Looking for recommendations/guidance here, will update as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Spice.ai OSS test target for FlightSQL C# interop driver to test compatibility with arrow-rs FlightSQL implementation.
SpiceAI
environment type support (test data, example configuration)FligthSQL C# Interop
integration tests. This can be extended to include more tests targets via configuration files similar toci/configs/flightsql-spiceai.json
added in this PRExample test run: https://github.com/apache/arrow-adbc/actions/runs/15597223474/job/43930217202?pr=2961
Testing against ADBC helped to identify and fix:
GetDbSchemas
andGetTables
schemas to fully match the protocol arrow-rs#7638