Skip to content

Provider apache-airflow-providers-microsoft-azure no longer==6.2.3 expose account_name #33203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
utkarsharma2 opened this issue Aug 8, 2023 · 5 comments · Fixed by #33457
Closed
2 tasks done
Assignees
Labels

Comments

@utkarsharma2
Copy link
Contributor

utkarsharma2 commented Aug 8, 2023

Apache Airflow version

2.6.3

What happened

Till version apache-airflow-providers-microsoft-azure no longer==6.2.2 if you do WasbHook(wasb_conn_id=self.conn_id).get_conn().account_name you will get the account_name But in version apache-airflow-providers-microsoft-azure==6.2.3 this is not longer working for below connection:

- conn_id: wasb_conn_with_access_key
    conn_type: wasb
    host: astrosdk.blob.core.windows.net
    description: null
    extra:
      shared_access_key: $AZURE_WASB_ACCESS_KEY

What you think should happen instead

We should get the account_name for apache-airflow-providers-microsoft-azure==6.2.3.

How to reproduce

Try installing the version apache-airflow-providers-microsoft-azure==6.2.3 and try running below code WasbHook(wasb_conn_id=self.conn_id).get_conn().account_name

Operating System

Mac

Versions of Apache Airflow Providers

No response

Deployment

Other Docker-based deployment

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@utkarsharma2 utkarsharma2 added kind:bug This is a clearly a bug area:core needs-triage label for new issues that we didn't triage yet provider:microsoft-azure Azure-related issues and removed needs-triage label for new issues that we didn't triage yet labels Aug 8, 2023
@eladkal
Copy link
Contributor

eladkal commented Aug 8, 2023

Assuming #32980 is the root cause we can also yank 6.2.3 as this PR is the only code change in the release
@ephraimbuddy @potiuk WDYT?

@ephraimbuddy
Copy link
Contributor

Assuming #32980 is the root cause we can also yank 6.2.3 as this PR is the only code change in the release @ephraimbuddy @potiuk WDYT?

Yes. that's the root cause. It appears that checking that host startswith https is wrong. I think the correct thing would be to use host however it's supplied but that's a breaking change that we fixed in 6.2.2 I think

@potiuk
Copy link
Member

potiuk commented Aug 8, 2023

Yes. We could yank the release.

@ephraimbuddy
Copy link
Contributor

ephraimbuddy commented Aug 8, 2023

Yes. We could yank the release.

I'm working out a solution but I don't think we should yank this. Specifying a value in connection.login will make the above connection work e.g:

- conn_id: wasb_conn_with_access_key
    conn_type: wasb
    login:astrosdk
    host: astrosdk.blob.core.windows.net
    description: null
    extra:
      shared_access_key: $AZURE_WASB_ACCESS_KEY

@potiuk
Copy link
Member

potiuk commented Aug 8, 2023

Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants