Skip to content

Commit 4037d79

Browse files
authored
Bring back wrong "hook-class-names" check (#33662)
Continuation of #33640 - there were one more wrong check in the provider, that missed "hook-class-names" check
1 parent 5dfbbbb commit 4037d79

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

scripts/in_container/run_provider_yaml_files_check.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -362,13 +362,14 @@ def check_completeness_of_list_of_transfers(yaml_files: dict[str, dict]):
362362
)
363363

364364

365-
def check_hook_connection_classes(yaml_files: dict[str, dict]):
365+
def check_hook_class_names(yaml_files: dict[str, dict]):
366366
print("Checking connection classes belong to package, exist and are classes")
367-
resource_type = "hook-class-names"
367+
resource_type = "connection-types"
368368
for yaml_file_path, provider_data in yaml_files.items():
369369
provider_package = pathlib.Path(yaml_file_path).parent.as_posix().replace("/", ".")
370-
hook_class_names = provider_data.get(resource_type)
371-
if hook_class_names:
370+
connection_types = provider_data.get(resource_type)
371+
if connection_types:
372+
hook_class_names = {connection_type["hook-class-name"] for connection_type in connection_types}
372373
check_if_objects_exist_and_belong_to_package(
373374
hook_class_names, provider_package, yaml_file_path, resource_type, ObjectType.CLASS
374375
)
@@ -598,7 +599,7 @@ def check_providers_have_all_documentation_files(yaml_files: dict[str, dict]):
598599

599600
check_completeness_of_list_of_transfers(all_parsed_yaml_files)
600601
check_duplicates_in_list_of_transfers(all_parsed_yaml_files)
601-
check_hook_connection_classes(all_parsed_yaml_files)
602+
check_hook_class_names(all_parsed_yaml_files)
602603
check_plugin_classes(all_parsed_yaml_files)
603604
check_extra_link_classes(all_parsed_yaml_files)
604605
check_correctness_of_list_of_sensors_operators_hook_trigger_modules(all_parsed_yaml_files)

0 commit comments

Comments
 (0)