Skip to content
This repository was archived by the owner on Apr 20, 2024. It is now read-only.

Commit e0459f5

Browse files
authored
Merge pull request #18 from aojea/sctp_ref
add references to the sctp bug
2 parents b3dda16 + 30fd7b1 commit e0459f5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pkg/networkpolicy/controller.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,14 @@ func (c *Controller) Run(ctx context.Context) error {
249249
go wait.Until(func() { c.syncNFTablesRules(ctx) }, 60*time.Second, ctx.Done())
250250
}
251251

252+
var flags uint32
252253
// https://netfilter.org/projects/libnetfilter_queue/doxygen/html/group__Queue.html
253254
// the kernel will not normalize offload packets,
254255
// i.e. your application will need to be able to handle packets larger than the mtu.
255256
// Normalization is expensive, so this flag should always be set.
256-
var flags uint32
257+
// This also solves a bug with SCTP
258+
// https://github.com/aojea/kube-netpol/issues/8
259+
// https://bugzilla.netfilter.org/show_bug.cgi?id=1742
257260
flags = nfqueue.NfQaCfgFlagGSO
258261
if c.config.FailOpen {
259262
flags += nfqueue.NfQaCfgFlagFailOpen

0 commit comments

Comments
 (0)