Skip to content

agave-ledger-tool verification with minimized snapshots #7087

@kbhargava-jump

Description

@kbhargava-jump

Now that lt-hash goes into the bank hash, the bank hashes for minimized snapshots are no longer the same for the full snapshots (for the same slot). Because of this, running the agave-ledger-tool verify command will now not work when using a minimized snapshot (will run into bank hash mismatches).

On the Firedancer side, when we run into mismatches, we minimize the snapshot with the mismatch slot in the range so that we can quickly and iteratively figure out what's going on. Once fixing, we put in our CI to make sure we don't regress from this new behavior.

Example of CI ledger addition: firedancer-io/firedancer#5773

Now that the bank hashes are different, we are unable to test the new correct behavior unless we also rewrite the bank hashes when using the agave-ledger-tool verify command, which is what we are currently doing.

Not sure what the correct / expected way to handle this but for now we will continue to rewrite rocksdb with updated bank hashes. Making this issue for awareness and after discussion with @brooksprumo. Thanks!

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions