Skip to content

fix(funnel): do not mutable data #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2021
Merged

fix(funnel): do not mutable data #2900

merged 3 commits into from
Oct 9, 2021

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Oct 8, 2021

PR includes

Screenshot

Before After

@hustcc hustcc requested a review from visiky October 8, 2021 12:32
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2021

🎊 PR Preview 75467e6 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2900.surge.sh?type=diff&date=2021-10-09

🕐 Build time: 131.316s

🤖 By surge-preview

@visiky
Copy link
Member

visiky commented Oct 9, 2021

这个是不是 漏斗图 内存泄漏的原因?

@hustcc
Copy link
Member Author

hustcc commented Oct 9, 2021

这个是不是 漏斗图 内存泄漏的原因?

应该不是,这个应该不会导致泄漏吧。

@visiky
Copy link
Member

visiky commented Oct 9, 2021

这个是不是 漏斗图 内存泄漏的原因?

应该不是,这个应该不会导致泄漏吧。

那就得继续看下哪里泄漏了 🧟‍♀️ 单测挂了

@hustcc
Copy link
Member Author

hustcc commented Oct 9, 2021

那就得继续看下哪里泄漏了 🧟‍♀️ 单测挂了

这个 mutable 的代码,后面还有依赖。我换了一个更直接干脆的办法了,直接在传入之前就线 clone 一下。

@coveralls
Copy link

coveralls commented Oct 9, 2021

Pull Request Test Coverage Report for Build 1322634548

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.633%

Totals Coverage Status
Change from base Build 1319574465: 0.0%
Covered Lines: 6811
Relevant Lines: 6933

💛 - Coveralls

@visiky visiky merged commit d92443e into master Oct 9, 2021
@visiky visiky deleted the do-not-mutable branch October 9, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants