Skip to content

fix(interaction): 添加 venn图 selected 和 active 的交互 #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2021
Merged

fix(interaction): 添加 venn图 selected 和 active 的交互 #2871

merged 3 commits into from
Sep 26, 2021

Conversation

Angelii
Copy link
Contributor

@Angelii Angelii commented Sep 23, 2021 •
edited
Loading

PR includes

  • fixed #0
  • demo
  • add / modify test cases
  • documents

Screenshot

image

@Angelii Angelii changed the title fix(interaction): 添加venn图的selected和active的交互 fix(interaction): 添加 venn图 selected 和 active 的交互 Sep 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2021 •
edited
Loading

🎊 PR Preview 4c9581c has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2871.surge.sh?type=diff&date=2021-09-26

🕐 Build time: 143.131s

🤖 By surge-preview

visiky
visiky reviewed Sep 26, 2021
View reviewed changes
visiky
visiky reviewed Sep 26, 2021
View reviewed changes
@Angelii Angelii force-pushed the fix-venn-interaction branch from ab4b2d9 to 77f4181 Compare September 26, 2021 11:23
@visiky
Copy link
Member

visiky commented Sep 26, 2021

build test 报错

visiky
visiky reviewed Sep 26, 2021
View reviewed changes
Copy link
Member

@visiky visiky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像文档说明还没有，参照下其他图表的drill-down 交互怎么写

@Angelii Angelii force-pushed the fix-venn-interaction branch from 77f4181 to 78a1a02 Compare September 26, 2021 11:46
@coveralls
Copy link

coveralls commented Sep 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1275151905

  • 48 of 48 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 95.621%
Totals Coverage Status
Change from base Build 1275035093: -0.001%
Covered Lines: 6819
Relevant Lines: 6941
💛 - Coveralls

@visiky visiky merged commit bf4b248 into master Sep 26, 2021
@visiky visiky deleted the fix-venn-interaction branch September 26, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky left review comments

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angelii @visiky @coveralls