fix: 修改桑基图 的 来源字段 type 类型为cat #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Apr 23, 2021
| @@ -77,7 +77,7 @@ function geometry(params: Params<SankeyOptions>): Params<SankeyOptions> { | |||
| chart.scale({ | |||
| x: { sync: true, nice: true, min: 0, max: 1, minLimit: 0, maxLimit: 1 }, | |||
| y: { sync: true, nice: true, min: 0, max: 1, minLimit: 0, maxLimit: 1 }, | |||
| name: { sync: 'color' }, | |||
| name: { sync: 'color', type: 'cat' }, | |||
There was a problem hiding this comment.
- 原来 是timecat 如果传入的是时间类型的来源字段， 其他不是时间的会呈现 默认颜色。 而传入的不是时间类型的来源字段。 颜色会按照顺序分配。
- 现在 是 cat 所以，无论是来源字段是 时间类型还是分类 颜色都是按照顺序分配
|
加一个单元测试吧，参考其他的写法。 |
hustcc
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes