Skip to content

玉钰图，数据值存在字符串数字渲染错误，存在字符串渲染崩溃 #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MrSmallLiu opened this issue Mar 4, 2021 · 2 comments
Closed

玉钰图，数据值存在字符串数字渲染错误，存在字符串渲染崩溃 #2394

MrSmallLiu opened this issue Mar 4, 2021 · 2 comments
Assignees
@MrSmallLiu
Labels
Good first issue Good for newcomers 异常数据

Comments

@MrSmallLiu
Copy link
Contributor

  • G2Plot Version:
  • Platform:
  • Mini Showcase(like screenshots):
  • CodePen Link:

数值为字符串类型数值渲染不对，如果是字符串导致崩溃。G2Plot官网示例可复现
image
@visiky visiky added the Good first issue Good for newcomers label Mar 4, 2021
@visiky
Copy link
Member

visiky commented Mar 4, 2021 •
edited
Loading

有没有人感兴趣来处理下这个 issue，参考饼图异常数据处理：#1321

  • 过滤掉不合法的数据，包括：文本、NaN等
  • 然后给出 warning 提示
  • 单测覆盖在异常情况

@MrSmallLiu
Copy link
Contributor Author

这个issue我来处理

MrSmallLiu added a commit to MrSmallLiu/G2Plot that referenced this issue Mar 14, 2021
@MrSmallLiu
fix(radial-bar): 非数字的数据图表崩溃antvis#2394
fb234e3
MrSmallLiu added a commit to MrSmallLiu/G2Plot that referenced this issue Mar 21, 2021
@MrSmallLiu
fix(radial-bar): filter illegal data antvis#2394
24c863c
MrSmallLiu added a commit to MrSmallLiu/G2Plot that referenced this issue Mar 23, 2021
@MrSmallLiu
fix(radial-bar): filter illegal data (antvis#2394)
aa2c5ad
visiky pushed a commit that referenced this issue Mar 23, 2021
@MrSmallLiu
fix(radial-bar): 修复玉钰图存在非法数据崩溃问题 (#2394) (#2447)
0f2bd78 
* fix(radial-bar): filter illegal data (#2394)

* fix(radial-bar): 过滤不合法数据不包含null，单测增加断言
@visiky visiky mentioned this issue Mar 24, 2021
Merged
3 tasks
@visiky visiky closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrSmallLiu MrSmallLiu

Labels
Good first issue Good for newcomers 异常数据
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@visiky @MrSmallLiu