Skip to content

feat(sankey): add nodeWidth, nodePadding options #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Feb 2, 2021

PR includes

依赖 G2 的 PR antvis/G2#3261

Screenshot

Before After

@hustcc hustcc requested review from lxfu1 and visiky February 2, 2021 14:03
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

😭 Deploy PR Preview de93e8c failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 530960077

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 96.685%

Files with Coverage Reduction New Missed Lines %
src/plots/sankey/index.ts 1 93.1%
Totals Coverage Status
Change from base Build 526466706: -0.009%
Covered Lines: 4784
Relevant Lines: 4833

💛 - Coveralls

Copy link
Member

@visiky visiky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@@ -120,6 +110,24 @@ function geometry(params: Params<SankeyOptions>): Params<SankeyOptions> {
},
});

const nodeView = chart.createView();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edgeView 和 nodeView 交换位置的原因是?

@hustcc hustcc merged commit 947889b into master Feb 2, 2021
@hustcc hustcc deleted the feat-sankey-tooltip branch February 2, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sankey bugs
3 participants