feat: 双轴图新增 slider #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

hustcc merged 8 commits into master from feat/dual-axes-slider

Feb 3, 2021

Member

lxfu1 commented Jan 29, 2021 •

edited

Loading

PR includes

fixed #0
add / modify test cases
documents, demos

Screenshot

Before	After
❌

|


          feat: 双轴图新增 slider

58ce35f

pr-triage bot added the PR: unreviewed label

Contributor

github-actions bot commented Jan 29, 2021 •

edited

Loading

😭 Deploy PR Preview bbbcae5 failed. Build logs

_{🤖 By surge-preview}

hustcc approved these changes

View reviewed changes

src/plots/dual-axes/adaptor.ts Outdated Show resolved Hide resolved

src/plots/dual-axes/util/renderWithSlider.ts Outdated Show resolved Hide resolved

src/plots/dual-axes/util/renderWithSlider.ts Outdated Show resolved Hide resolved

src/plots/dual-axes/util/renderWithSlider.ts Outdated Show resolved Hide resolved

src/plots/dual-axes/util/renderWithSlider.ts Outdated Show resolved Hide resolved

src/plots/dual-axes/util/renderWithSlider.ts Outdated Show resolved Hide resolved

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels


          feat: 补充 slider 单测

699f015

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels


          fix: ci

bbbcae5

Member Author

lxfu1 commented Feb 2, 2021

有个单测问题，依赖 G2 https://github.com/antvis/G2/pull/3258/files

hustcc reviewed

View reviewed changes

src/utils/is-between.ts Outdated Show resolved Hide resolved


          fix: isBetween 移入 number 中

026a9ab

Member

hustcc commented Feb 3, 2021

求加个截图，方便发 changelog~

hustcc reviewed

View reviewed changes

__tests__/unit/plots/dual-axes/slider-spec.ts Show resolved Hide resolved

hustcc reviewed

View reviewed changes

__tests__/unit/plots/dual-axes/slider-spec.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

__tests__/unit/plots/dual-axes/slider-spec.ts Show resolved Hide resolved

hustcc reviewed

View reviewed changes

examples/dual-axes/column-line/demo/demo-more-2.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/dual-axes/adaptor.ts Show resolved Hide resolved

coveralls commented Feb 3, 2021 •

edited

Loading

Pull Request Test Coverage Report for Build 533034307

26 of 27 (96.3%) changed or added relevant lines in 4 files are covered.
11 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.2%) to 96.554%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/plots/dual-axes/util/render-sider.ts	20	21	95.24%

Files with Coverage Reduction	New Missed Lines	%
src/plots/multi-view/adaptor.ts	1	96.72%
src/plots/treemap/interactions/actions/treemap-drill-down-action.ts	2	90.24%
src/plots/box/adaptor.ts	4	92.73%
src/plots/dual-axes/adaptor.ts	4	95.5%

Totals
Change from base Build 519973899:	-0.2%
Covered Lines:	4827
Relevant Lines:	4880

💛 - Coveralls

liufu.lf added 2 commits

February 3, 2021 14:23


          fix: reolve conversation

61bd749


          docs: 补充文档

2e7851e

hustcc approved these changes

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels


          fix: confict

35ecb91

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels


          Merge branch 'master' into feat/dual-axes-slider

6bb8c2a

hustcc merged commit 0276528 into master

hustcc deleted the feat/dual-axes-slider branch

February 3, 2021 08:07

pr-triage bot added PR: merged and removed PR: unreviewed labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels