Skip to content

fix(word-cloud): 由于无法判断首次 render 是否ready，changedata时，如果有 imageMask，重渲染 #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

fix(word-cloud): 由于无法判断首次 render 是否ready，changedata时，如果有 imageMask，重渲染 #2252

merged 1 commit into from
Jan 20, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 20, 2021

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@visiky visiky requested review from hustcc and lxfu1 January 20, 2021 09:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 498133033

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 96.839%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plots/word-cloud/index.ts 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
src/plots/word-cloud/index.ts 1 90.91%
Totals Coverage Status
Change from base Build 497521719: 0.002%
Covered Lines: 4605
Relevant Lines: 4642
💛 - Coveralls

@lxfu1 lxfu1 merged commit b5fe647 into master Jan 20, 2021
@lxfu1 lxfu1 deleted the fix-wordcloud-changedata branch January 20, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxfu1 lxfu1 lxfu1 approved these changes

@hustcc hustcc Awaiting requested review from hustcc

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @lxfu1