Skip to content

feat(progress): 进度条&环形进度条支持 changeData #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2021
Merged

feat(progress): 进度条&环形进度条支持 changeData #2197

merged 1 commit into from
Jan 10, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 10, 2021

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@visiky visiky requested a review from hustcc January 10, 2021 02:29
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2021 •
edited
Loading

😭 Deploy PR Preview 17b962d failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 474945236

  • 17 of 17 (100.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 96.848%
Files with Coverage Reduction New Missed Lines %
src/plots/ring-progress/adaptor.ts 1 93.02%
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 474906163: -0.02%
Covered Lines: 4535
Relevant Lines: 4573
💛 - Coveralls

@hustcc hustcc merged commit 0788dbf into master Jan 10, 2021
@hustcc hustcc deleted the progress-plot branch January 10, 2021 08:48
@visiky visiky added this to the change-data milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
change-data
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc