feat: 迷你折线图和迷你柱形图重写changeData && 添加单测 #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 465392983
💛 - Coveralls |
hustcc
reviewed
Jan 5, 2021
visiky
reviewed
Jan 6, 2021
hustcc
reviewed
Jan 6, 2021
src/utils/getTinyData.ts
Outdated
|
|
||
| export function getTinyData(data: number[]) { | ||
| return map(data || [], (y: number, x: number) => { | ||
| return { x, y }; |
There was a problem hiding this comment.
x:
${x}
变成字符串。这个方法直接放到 plots/line 里面的 util 吧，其他图从 line 里面引入即可。
hustcc
reviewed
Jan 6, 2021
src/plots/tiny-column/index.ts
Outdated
| */ | ||
| public changeData(data: TinyColumnOptions['data']) { | ||
| this.updateOption({ data }); | ||
| const newData = map(data, (y: number, x: number) => { |
There was a problem hiding this comment.
getTinyData，同理 column 的 adaptor 中也用 getTinyData
hustcc
reviewed
Jan 6, 2021
| const inValidData_2 = getTinyData(null); | ||
| expect(inValidData_2).toEqual([]); | ||
| }); | ||
| }); |
yp0413150120
changed the title
|
This pull request introduces 1 alert when merging 11db37d into b46e6b3 - view on LGTM.com new alerts:
|
hustcc
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
override the changeData method of tiny-line