-
Notifications
You must be signed in to change notification settings - Fork 601
[漏斗图] 暴露转化率给用户 #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[漏斗图] 暴露转化率给用户 #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzhenying
commented
Dec 29, 2020
hustcc
reviewed
Dec 29, 2020
😭 Deploy PR Preview 5d79ef2 failed. Build logs 🤖 By surge-preview |
Pull Request Test Coverage Report for Build 452224209
💛 - Coveralls |
@liuzhenying 暴露图表内部的字段名称,迟早的事情,漏斗图第一个来搞,点赞。 但是建议不是以 static 属性的方式,而是直接 export 吧,可以做一个规范,比如: 对于这个,其他同学看有没有一些想法,这个迟早要处理了。 |
hustcc
reviewed
Dec 30, 2020
hustcc
approved these changes
Dec 30, 2020
决定方案:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
暴露 FUNNEL_CONVERSATION 变量,同时规范并修复使用此变量的 demo