Skip to content

[漏斗图] 暴露转化率给用户 #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 30, 2020
Merged

[漏斗图] 暴露转化率给用户 #2159

merged 5 commits into from
Dec 30, 2020

Conversation

liuzhenying
Copy link
Member

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

暴露 FUNNEL_CONVERSATION 变量,同时规范并修复使用此变量的 demo

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2020

😭 Deploy PR Preview 5d79ef2 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Dec 29, 2020

Pull Request Test Coverage Report for Build 452224209

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 96.773%

Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 450830519: -0.03%
Covered Lines: 4411
Relevant Lines: 4449

💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Dec 29, 2020

@liuzhenying 暴露图表内部的字段名称,迟早的事情,漏斗图第一个来搞,点赞。

但是建议不是以 static 属性的方式,而是直接 export 吧,可以做一个规范,比如:${plotType}_${fieldName}_FIELD

对于这个,其他同学看有没有一些想法,这个迟早要处理了。

@hustcc hustcc merged commit 222af2f into master Dec 30, 2020
@hustcc hustcc deleted the fix/funnel-docs-demo branch December 30, 2020 07:44
@hustcc
Copy link
Member

hustcc commented Dec 30, 2020

决定方案:

  1. 直接 export 变量
  2. 规范: ${plotType}_${fieldName}_FIELD (全大写)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants