Skip to content

feat: area support changeData #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 29, 2020
Merged

feat: area support changeData #2153

merged 6 commits into from
Dec 29, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Dec 28, 2020

PR includes

  • add / modify test cases

Screenshot

截图都是 gif,新 tab 打开可见

Before After

@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2020

This pull request introduces 1 alert when merging e0f059f into ac17235 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2020

😭 Deploy PR Preview 8debfca failed. Build logs

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2020

This pull request introduces 1 alert when merging 6baf404 into ac17235 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@coveralls
Copy link

coveralls commented Dec 28, 2020

Pull Request Test Coverage Report for Build 450150881

  • 11 of 11 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.771%

Totals Coverage Status
Change from base Build 448753350: 0.02%
Covered Lines: 4408
Relevant Lines: 4446

💛 - Coveralls

@lgtm-com
Copy link

lgtm-com bot commented Dec 29, 2020

This pull request introduces 1 alert when merging 3b8f408 into ac17235 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@visiky visiky requested review from hustcc and lessmost December 29, 2020 01:29
@visiky visiky force-pushed the feat-area-changedata branch from d71f8f0 to 4459ea5 Compare December 29, 2020 01:37
@lgtm-com
Copy link

lgtm-com bot commented Dec 29, 2020

This pull request introduces 1 alert when merging 4459ea5 into ac17235 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@hustcc
Copy link
Member

hustcc commented Dec 29, 2020

牛逼哦~

@hustcc
Copy link
Member

hustcc commented Dec 29, 2020

两个 CR 建议,不强制,但是出现的 lint 要不这个分支搞掉吧。

@hustcc hustcc self-requested a review December 29, 2020 05:19
@lgtm-com
Copy link

lgtm-com bot commented Dec 29, 2020

This pull request introduces 1 alert when merging 6dfb3a6 into ac17235 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@visiky visiky force-pushed the feat-area-changedata branch from 6dfb3a6 to 8debfca Compare December 29, 2020 05:34
@lgtm-com
Copy link

lgtm-com bot commented Dec 29, 2020

This pull request introduces 1 alert when merging 8debfca into ac17235 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc merged commit 4a8ef9f into master Dec 29, 2020
@hustcc hustcc deleted the feat-area-changedata branch December 29, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants