Skip to content

fix: fix duplicated label renderde for line and area plot #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix: fix duplicated label renderde for line and area plot #2071

merged 1 commit into from
Dec 7, 2020

Conversation

lessmost
Copy link
Member

@lessmost lessmost commented Dec 4, 2020 •
edited
Loading

  • 给 geometry adaptor 添加 config 配置，允许 geometry adaptor 跳过某些步骤
  • line/area/radar 等大部分图形有自己的 label adaptor，需要调整基础 geometry 中内置的 label 处理逻辑

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020 •
edited
Loading

😭 Deploy PR Preview 835f6f2 failed. Build logs

🤖 By surge-preview

@lessmost lessmost force-pushed the fix-line-area-duplicated-label branch from 95832d6 to 906411d Compare December 4, 2020 09:08
@lessmost lessmost requested review from hustcc and visiky and removed request for hustcc December 4, 2020 09:09
@coveralls
Copy link

coveralls commented Dec 4, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 400415303

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.64%
Totals Coverage Status
Change from base Build 398625751: 0.0%
Covered Lines: 4134
Relevant Lines: 4172
💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Dec 4, 2020

  1. 覆盖率又低了一些。
  2. 前后对比图，方便下周的内容

@hustcc
Copy link
Member

hustcc commented Dec 4, 2020

为啥不是在 area 中使用 line, area, point adaptor 的时候，分别传入 label 为 false？

@lessmost lessmost force-pushed the fix-line-area-duplicated-label branch from cc9cb6a to 835f6f2 Compare December 4, 2020 10:09
@lessmost
Copy link
Member Author

lessmost commented Dec 4, 2020

  1. 覆盖率又低了一些。
  2. 前后对比图，方便下周的内容

这个截图肉眼基本看不出来，一个文本绘制两边看不出来

@hustcc hustcc merged commit 66a1088 into master Dec 7, 2020
@hustcc hustcc deleted the fix-line-area-duplicated-label branch December 7, 2020 07:10
@lessmost lessmost mentioned this pull request Dec 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lessmost @coveralls @hustcc