Skip to content

fix(bar): adjust default legend and tooltip order #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Conversation

lessmost
Copy link
Member

@lessmost lessmost commented Dec 1, 2020

关联 PR antvis/G2#3055

条形图中,按照设计师的需求,数据是从上玩下看,实现方式是对数据逆序,导致图例/tooltip的顺序和柱子视觉顺序在某些情况不一致,所以在 G2Plot 中对条形图的默认选项做对应调整:

before after
image image

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

😭 Deploy PR Preview 067c752 failed. Build logs

🤖 By surge-preview

@lessmost lessmost requested review from hustcc and visiky December 1, 2020 13:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 395472480

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 96.696%

Totals Coverage Status
Change from base Build 391708637: -0.03%
Covered Lines: 4003
Relevant Lines: 4038

💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Dec 2, 2020

单测报错了。

@hustcc hustcc merged commit d292545 into master Dec 2, 2020
@hustcc hustcc deleted the fix-bar-legend-seq branch December 2, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants