Skip to content

fix: 双轴图 label.formatter #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

fix: 双轴图 label.formatter #2033

merged 1 commit into from
Nov 30, 2020

Conversation

liuzhenying
Copy link
Member

  • 双轴图 label 支持 formatter，因公共 base geometry 中绘制出了 label，去除 plot 中自定义，避免重复绘制
  • 去除一些 unused 引用
  • test
  • demo

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2020 •
edited
Loading

😭 Deploy PR Preview e472ec5 failed. Build logs

🤖 By surge-preview

@liuzhenying liuzhenying changed the title fix: 双轴图 label 支持 formatter fix: 双轴图 label.formatter Nov 30, 2020
@liuzhenying liuzhenying requested review from hustcc and visiky and removed request for hustcc November 30, 2020 13:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 391673565

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 96.722%
Totals Coverage Status
Change from base Build 391219881: -0.005%
Covered Lines: 3998
Relevant Lines: 4033
💛 - Coveralls

@hustcc hustcc merged commit 59d636a into master Nov 30, 2020
@hustcc hustcc deleted the feat/duax-label-formatter branch November 30, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuzhenying @coveralls @hustcc