Skip to content

feat: treemap init #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 30, 2020
Merged

feat: treemap init #2023

merged 5 commits into from
Dec 30, 2020

Conversation

liuzhenying
Copy link
Member

@liuzhenying liuzhenying commented Nov 29, 2020

  • 矩形树图
  • 嵌套矩形树图
  • label 等基础组件
  • test
  • demo
  • docs

矩形树图

Before After
屏幕快照 2020-12-25 11 09 25
新增矩形树图

嵌套矩形树图

Before After
屏幕快照 2020-12-30 14 26 58
新增嵌套矩形树图

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2020

😭 Deploy PR Preview 3ecba6d failed. Build logs

🤖 By surge-preview

@hustcc
Copy link
Member

hustcc commented Dec 2, 2020

一鼓作气~

  • pr 截图来几张
  • 单测
  • 文档
  • demo

剩下的下钻的交互,可以下一次 pr 来。

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2020

😭 Deploy PR Preview 3bb1113 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Dec 25, 2020

Pull Request Test Coverage Report for Build 452138477

  • 51 of 51 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 96.787%

Totals Coverage Status
Change from base Build 442312124: 0.04%
Covered Lines: 4460
Relevant Lines: 4498

💛 - Coveralls

@liuzhenying liuzhenying changed the title [WIP] feat: treemap init feat: treemap init Dec 25, 2020
@liuzhenying liuzhenying changed the title feat: treemap init [WIP] feat: treemap init Dec 25, 2020
@liuzhenying liuzhenying changed the title [WIP] feat: treemap init feat: treemap init Dec 25, 2020
@hustcc
Copy link
Member

hustcc commented Dec 29, 2020

拍个板,定个结论吧。不然一直停止不前,di 替换一直推延。

  1. 矩阵树图、旭日图的数据结构都限定死为 name value children 的递归结构,而不再使用 xxField 去作区分。
  2. 旭日图 临时做兼容,文档更新到第一条。

原因:矩阵树图、旭日图是递归结构,如果要指定 xxField,那么一定就要指定 nameField,valueField,childrenField,挺奇怪,再加上竞品确实是直接从数据结构上做约束的。

@hustcc hustcc merged commit 45808e3 into master Dec 30, 2020
@hustcc hustcc deleted the feat/treemap branch December 30, 2020 07:43
@pr-triage pr-triage bot added the PR: merged label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants