Skip to content

feat: 打开 limit in plot 配置 #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 24, 2020
Merged

feat: 打开 limit in plot 配置 #2002

merged 3 commits into from
Nov 24, 2020

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Nov 24, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2020 •
edited
Loading

😭 Deploy PR Preview d8de444 failed. Build logs

🤖 By surge-preview

hustcc
hustcc reviewed Nov 24, 2020
View reviewed changes
src/core/plot.ts Outdated
@@ -60,6 +61,7 @@ export abstract class Plot<O extends PickOptions> extends EE {
pixelRatio,
syncViewPadding,
supportCSSTransform,
limitInPlot = false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用设置默认值。

hustcc
hustcc reviewed Nov 24, 2020
View reviewed changes
src/core/plot.ts
@@ -74,7 +76,7 @@ export abstract class Plot<O extends PickOptions> extends EE {
syncViewPadding,
supportCSSTransform,
/** 图形不超出画布 */
limitInPlot: false,
limitInPlot,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上面的注释也删除，

@hustcc
Copy link
Member

hustcc commented Nov 24, 2020

单测报错了。

@coveralls
Copy link

coveralls commented Nov 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 381148977

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.59%
Totals Coverage Status
Change from base Build 380228559: 0.0%
Covered Lines: 3948
Relevant Lines: 3986
💛 - Coveralls

@hustcc hustcc merged commit 65b485d into master Nov 24, 2020
@hustcc hustcc deleted the feat/limit-in-plot branch November 24, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG]双轴图y轴设置最大值时渲染出来会超过图例
3 participants
@lxfu1 @hustcc @coveralls