Skip to content

docs: 更新manual英文文档 #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2020
Merged

docs: 更新manual英文文档 #1906

merged 3 commits into from
Nov 17, 2020

Conversation

DarrenPei
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2020 •
edited
Loading

😭 Deploy PR Preview 81db5ca failed. Build logs

🤖 By surge-preview

hustcc
hustcc reviewed Nov 12, 2020
View reviewed changes
docs/manual/graphic-style.en.md
| shadowOffsetX | number | 设置阴影距文字的水平距离 |
| shadowOffsetY | number | 设置阴影距文字的垂直距离 |
| cursor | string | 鼠标样式。同 css 的鼠标样式,默认 'default'。 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table 里面的内容没有翻译。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table里的下一批次改,一次传太多看不过来

hustcc
hustcc reviewed Nov 12, 2020
View reviewed changes
docs/manual/plugin.en.md Outdated
1. Define chart default configuration
2. Custom adaptor to realize the transformation from configuration to G2 API
3. Use it on G2Plot, or produce NPM package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

produce -> release ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没想到好的翻译,可以用publish,参考https://www.npmjs.cn/getting-started/publishing-npm-packages/

hustcc
hustcc reviewed Nov 12, 2020
View reviewed changes
docs/manual/plugin.en.md


## Customized third-party charts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有的 chart 都用 plot 吧，毕竟叫 G2Plot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK统一吧

@coveralls
Copy link

coveralls commented Nov 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 367146708

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.161%
Totals Coverage Status
Change from base Build 365855591: 0.0%
Covered Lines: 3844
Relevant Lines: 3894
💛 - Coveralls

@hustcc hustcc merged commit d8aea09 into antvis:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarrenPei @coveralls @hustcc