Skip to content

fix: Scatter regression line and Dual Axes change data #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Nov 3, 2020

  • 修复散点图 regressionLine 被二次 scale,legend 无效。
  • 修复 DualAxes changeData geometryOptions 丢失

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

😭 Deploy PR Preview 654c8e1 failed. Build logs

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request introduces 3 alerts when merging e6c2d24 into 2ae9c9e - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@coveralls
Copy link

coveralls commented Nov 3, 2020

Pull Request Test Coverage Report for Build 343441161

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 93.493%

Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.82%
src/plots/scatter/adaptor.ts 2 88.46%
src/utils/path.ts 9 74.19%
Totals Coverage Status
Change from base Build 343288678: -0.3%
Covered Lines: 3559
Relevant Lines: 3673

💛 - Coveralls

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request introduces 3 alerts when merging 1ea1f68 into 2ae9c9e - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@hustcc hustcc merged commit 654c8e1 into master Nov 3, 2020
@hustcc hustcc deleted the fix/bugs branch November 3, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants