Skip to content

fix: type define of legend, axis #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2020
Merged

fix: type define of legend, axis #1842

merged 3 commits into from
Nov 3, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Nov 3, 2020

类型定义只允许 false(true 可用但是不建议,使用方式上统一)

  • legend
  • axis

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

😭 Deploy PR Preview 8f035d8 failed. Build logs

🤖 By surge-preview

@hustcc hustcc requested review from visiky and lxfu1 November 3, 2020 03:48
@jaredleechn
Copy link

jaredleechn commented Nov 3, 2020

check more for

  • animation
  • axis.label.autoRotate
  • axis.label.autoHide
  • axis.label.autoEllipsis
  • label.callback.returnType.labelLine
  • state.default.arguments.0.animate
  • state.default.arguments.0.geometry.tooltipOption
  • state.default.arguments.0.geometry.animateOption
  • state.default.arguments.0.geometry.tooltip.arguments.0

@hustcc
Copy link
Member Author

hustcc commented Nov 3, 2020

check more for

  • animation
  • axis.label.autoRotate
  • axis.label.autoHide
  • axis.label.autoEllipsis
  • label.callback.returnType.labelLine
  • state.default.arguments.0.animate
  • state.default.arguments.0.geometry.tooltipOption
  • state.default.arguments.0.geometry.animateOption
  • state.default.arguments.0.geometry.tooltip.arguments.0

animate 是顶层 G2Plot 可以控制的,再内部的暂时就直接 follow G2 的定义,不做修改了。

@hustcc hustcc requested a review from lxfu1 November 3, 2020 11:00
@hustcc hustcc merged commit 8f035d8 into master Nov 3, 2020
@hustcc hustcc deleted the fix-type-define branch November 3, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants