Skip to content

fix: coveralls ci not working #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2020
Merged

fix: coveralls ci not working #1829

merged 2 commits into from
Oct 30, 2020

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Oct 30, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2020 •
edited
Loading

😭 Deploy PR Preview f2bef05 failed. Build logs

🤖 By surge-preview

@afc163 afc163 changed the title fix: coveralls ci not working [WIP] fix: coveralls ci not working Oct 30, 2020
@afc163 afc163 closed this Oct 30, 2020
@afc163 afc163 reopened this Oct 30, 2020
@afc163 afc163 changed the title [WIP] fix: coveralls ci not working fix: coveralls ci not working Oct 30, 2020
@hustcc
Copy link
Member

hustcc commented Oct 30, 2020

这个 pr 就能刚看到效果吗。

@afc163
Copy link
Contributor Author

afc163 commented Oct 30, 2020

这个 pr 就能刚看到效果吗。

不确定，我先试试。

@afc163
Copy link
Contributor Author

afc163 commented Oct 30, 2020

文档怎么这么大

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 337502246

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.26%
Totals Coverage Status
Change from base Build 337471165: 0.04%
Covered Lines: 3535
Relevant Lines: 3649
💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Oct 30, 2020

文档怎么这么大

image

比 G2 多一些，但是不到两倍，现在有一部分重复，下周处理完，不过应该也只是减少30−40%。

@hustcc hustcc merged commit f2bef05 into master Oct 30, 2020
@hustcc hustcc deleted the fix-coveralls branch October 30, 2020 11:30
afc163
afc163 commented Oct 30, 2020
View reviewed changes
.github/workflows/ci.yml
@@ -1,6 +1,6 @@
name: CI

on: [push]
on: [push, pull_request]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

底下有几个 lint 问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: unreviewed
Projects
None yet
Milestone
No milestone
3 participants
@afc163 @hustcc @coveralls