Skip to content

fix(line): when data all gt 0, or lt 0, set the default min/max #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2020
Merged

fix(line): when data all gt 0, or lt 0, set the default min/max #1788

merged 2 commits into from
Oct 26, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Oct 26, 2020

  • Meta 定义和 Axis 重复的直接复用
  • 调整折线图 Y min/max
  • 增加单侧

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2020 •
edited
Loading

🎊 PR Preview 76236d2 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1788.surge.sh

🕐 Build time: 610.571s

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2020

This pull request introduces 3 alerts when merging 3b7b5da into feb7541 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2020

This pull request fixes 5 alerts when merging 8b388cb into feb7541 - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2020

This pull request fixes 5 alerts when merging 489d217 into feb7541 - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@hustcc hustcc force-pushed the fix-line-scale-zero branch from 489d217 to b23b469 Compare October 26, 2020 09:46
@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2020

This pull request fixes 5 alerts when merging b23b469 into 448ee0d - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@hustcc hustcc requested review from lxfu1 and visiky October 26, 2020 10:17
@hustcc hustcc merged commit 76236d2 into master Oct 26, 2020
@hustcc hustcc deleted the fix-line-scale-zero branch October 26, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcc @visiky