feat: tooltip, label 增加 formatter 能力 #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lxfu1
commented
Oct 15, 2020
•
lxfu1
commented
- fixed v2 雷达图 legend 配置无效 #1727
- 新增 tooltip formatter, fixed 建议 tooltip 补充 formatter 方法 #1724
- 抽取 percent customContent
- Radar 新增 label 支持
|
😭 Deploy PR Preview 58f363c failed. Build logs
🤖 By surge-preview |
visiky
requested changes
Oct 15, 2020
|
|
||
| const geometry = findGeometry(chart, 'line'); | ||
|
|
||
| if (!label) { |
There was a problem hiding this comment.
这个直接判断 false 会遗漏，例如 null、undefined等，感觉不友好。
hustcc
reviewed
Oct 15, 2020
|
tooltip.formatter 的单测。包括 util 中的几个 transform 函数的单测。 |
utils/transform-tooltip-spec.ts |
hustcc
approved these changes
Oct 16, 2020
hustcc
approved these changes
Oct 16, 2020
auto-add-label
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.