Skip to content

refactor(ring): 环图中心文本统一结构 #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

visiky
Copy link
Member

@visiky visiky commented Sep 17, 2020

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2020

This pull request introduces 2 alerts when merging 76aa656 into c9245ee - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

}

if (percentage.endsWith('%')) {
return Number(percentage.slice(0, -1)) * 0.01;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 理论上 / 100 的可读性更高。

@@ -49,43 +47,6 @@ describe('utils of pie plot', () => {
).toBe(null);
});

it('getStatisticData: 单色饼图', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个方法被删除了吗?

@hustcc hustcc self-requested a review September 17, 2020 11:39
@hustcc hustcc merged commit b15334d into master Sep 17, 2020
@hustcc hustcc deleted the ring-statistic branch September 17, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants