Skip to content

feat: v2增强子弹图 #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2020
Merged

feat: v2增强子弹图 #1566

merged 2 commits into from
Sep 14, 2020

Conversation

arcsin1
Copy link
Contributor

@arcsin1 arcsin1 commented Sep 12, 2020

  1. 首先修复某个分支被合并掉的代码;
  2. 支持竖着方向的子弹图 关于子弹图的方向 #1560

@auto-add-label auto-add-label bot added the Bug Something isn't working label Sep 12, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 12, 2020

This pull request fixes 1 alert when merging ba94adb into b8e6a4b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@visiky
Copy link
Member

visiky commented Sep 12, 2020

竖者是否可以直接支持一个配置开关,类似layout: horizontal,vertical 就好 @hustcc

@arcsin1 arcsin1 changed the title fix: 修复之前v2-bullet合并问题 feat: v2增强子弹图 Sep 13, 2020
@auto-add-label auto-add-label bot added enhancement New feature or request and removed Bug Something isn't working labels Sep 13, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 13, 2020

This pull request fixes 1 alert when merging 499b1b7 into b8e6a4b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hustcc
Copy link
Member

hustcc commented Sep 14, 2020

剩下几个可能是问题的地方:

  1. geometry 的构造,参考 radar,使用统一的方式去创建
  2. measureStyle 等 的类型定义统一都使用 StyleAttr。
  3. 默认的 legend 配置

@hustcc hustcc merged commit 37e0c31 into antvis:master Sep 14, 2020
@arcsin1
Copy link
Contributor Author

arcsin1 commented Sep 14, 2020

剩下几个可能是问题的地方:

  1. geometry 的构造,参考 radar,使用统一的方式去创建
  2. measureStyle 等 的类型定义统一都使用 StyleAttr。
  3. 默认的 legend 配置

嗯嗯 我看了你们写的,这个版本改的话 ,改造有点大,准备下个feature更改

@phoema
Copy link

phoema commented Sep 15, 2020

你们好,新版本子弹图目标值是否能显示?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants