feat(v2): 添加玫瑰图配置项 #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

hustcc merged 9 commits into antvis:master from zhangzhonghe:feat/rose

Aug 29, 2020

Member

zhangzhonghe commented Aug 18, 2020 •

edited by hustcc

Loading

auto-add-label bot added the enhancement label

pr-triage bot added the PR: unreviewed label

zhangzhonghe force-pushed the feat/rose branch from fc1a718 to 277f6ac Compare

August 18, 2020 04:26

zhangzhonghe changed the title ~~feat: 添加玫瑰图配置项~~ feat(v2): 添加玫瑰图配置项

hustcc reviewed

View reviewed changes

src/plots/rose/types.ts Show resolved Hide resolved

lxfu1 reviewed

View reviewed changes

src/plots/rose/index.ts Outdated Show resolved Hide resolved

lxfu1 reviewed

View reviewed changes

src/plots/rose/adaptor.ts Outdated Show resolved Hide resolved

lxfu1 reviewed

View reviewed changes

src/plots/rose/adaptor.ts Outdated Show resolved Hide resolved

lxfu1 reviewed

View reviewed changes

src/plots/rose/adaptor.ts Show resolved Hide resolved

lxfu1 reviewed

View reviewed changes

src/plots/rose/adaptor.ts Outdated Show resolved Hide resolved

zhangzhonghe force-pushed the feat/rose branch from dcd3f9a to d26477f Compare

August 20, 2020 02:20

visiky reviewed

View reviewed changes

src/plots/rose/adaptor.ts Outdated Show resolved Hide resolved

src/plots/rose/adaptor.ts Outdated Show resolved Hide resolved

src/plots/rose/adaptor.ts Outdated Show resolved Hide resolved

src/plots/rose/index.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/rose/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/rose/types.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

__tests__/unit/plots/rose/animation-spec.ts Outdated Show resolved Hide resolved

Member

hustcc commented Aug 29, 2020

周一确认一下，是否柱形图、条形图也统一子弹配置为： xField、yField、seriesField isGroup、isStack。

后面如果真的需要 colorField， groupField，stackField。再加也不难，但是我们加上去之后，再想删除简化就难了~

zhangzhonghe added 9 commits

August 29, 2020 15:51


          feat: 添加玫瑰图配置项

93273a1


          feat(v2): 添加玫瑰图adaptor(50%)

3af4672


          feat(v2): 添加玫瑰图adaptor(65%)


          chore(v2): use deepMix

45bcb0a


          feat(v2): 添加玫瑰图adaptor(70%)，并优化代码

a88dffb


          chore: 优化代码

c40dc91


          test(v2): 为玫瑰图添加测试

96e5ace


          feat(v2): 参照柱状图为玫瑰图添加分组和堆叠选项

b576c5f


          refactor(v2/rose): 只保留seriesField字段

84a6c84

zhangzhonghe force-pushed the feat/rose branch from a5d4a52 to 84a6c84 Compare

August 29, 2020 07:52

hustcc reviewed

View reviewed changes

__tests__/unit/plots/rose/style-spec.ts Show resolved Hide resolved

hustcc approved these changes

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels

hustcc merged commit a9cbbd2 into antvis:master

pr-triage bot added PR: merged and removed PR: reviewed-approved labels

hustcc mentioned this pull request

refactor: remove groupField, colorField, stackField in bar and column #1529

Merged

3 tasks

zhangzhonghe deleted the feat/rose branch

September 17, 2020 15:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PR: merged