feat: v2版子弹图bullet初稿 #1427

arcsin1 · 2020-08-13T09:07:18Z

#1384 v2版子弹图bullet初稿

V2

增加histogram的文档

src/plots/bullet/adaptor.ts

… v2-histogram

visiky · 2020-08-21T00:19:00Z

嗨，子弹图在写单测的时候，可以判断下图例是否在展示区域内，相关 issue 见 #1442

const chart = plot.chart
const legendBBox = chart.getController('legend').getComponents()[0].component.getBBox();
const viewBBox = chart.viewBBox;

// 判断 legendBBox 是否在 viewBBox 内

arcsin1 · 2020-08-21T00:42:44Z

嗨，子弹图在写单测的时候，可以判断下图例是否在展示区域内，相关 issue 见 #1442
const chart = plot.chart
const legendBBox = chart.getController('legend').getComponents()[0].component.getBBox();
const viewBBox = chart.viewBBox;

// 判断 legendBBox 是否在 viewBBox 内

好的我注意这个

visiky · 2020-08-21T00:51:35Z

嗨，子弹图在写单测的时候，可以判断下图例是否在展示区域内，相关 issue 见 #1442
const chart = plot.chart
const legendBBox = chart.getController('legend').getComponents()[0].component.getBBox();
const viewBBox = chart.viewBBox;

// 判断 legendBBox 是否在 viewBBox 内
好的我注意这个

👍

我刚刚看了下 v1 版本的，好像这样子判断还不够，需要在判断下legendBBox minX、minY 是否小于 0（避免被其他误伤，导致被隐藏）

arcsin1 · 2020-08-21T00:54:20Z

嗨，子弹图在写单测的时候，可以判断下图例是否在展示区域内，相关 issue 见 #1442
const chart = plot.chart
const legendBBox = chart.getController('legend').getComponents()[0].component.getBBox();
const viewBBox = chart.viewBBox;

// 判断 legendBBox 是否在 viewBBox 内
好的我注意这个
👍

我刚刚看了下 v1 版本的，好像这样子判断还不够，需要在判断下legendBBox minX、minY 是否小于 0（避免被其他误伤，导致被隐藏）

arcsin1 · 2020-08-21T00:55:50Z

嗨，子弹图在写单测的时候，可以判断下图例是否在展示区域内，相关 issue 见 #1442
const chart = plot.chart
const legendBBox = chart.getController('legend').getComponents()[0].component.getBBox();
const viewBBox = chart.viewBBox;

// 判断 legendBBox 是否在 viewBBox 内
好的我注意这个
👍
我刚刚看了下 v1 版本的，好像这样子判断还不够，需要在判断下legendBBox minX、minY 是否小于 0（避免被其他误伤，导致被隐藏）

刚按错了，嗯嗯，会判断的

arcsin1 · 2020-08-25T07:57:26Z

// TODO 准备最近几天画一个设计图写一些思考来参考，不过最近时间不太葱郁，可能会晚点出来！

src/plots/bullet/utils.ts

hustcc · 2020-08-29T05:37:08Z

src/plots/bullet/adaptor.ts

+    });
+
+    // 做好排序兼容
+    const ranges = data[i].ranges.sort((a, b) => a - b);


sort 是会改变原数据吧~

src/plots/bullet/adaptor.ts

src/plots/bullet/types.ts

hustcc · 2020-08-29T06:20:14Z

周一在联系讨论：

具体多子弹图的实现方案，使用多 view 还是单 view
解决多子弹图，统一度量、不统一度量给出解决办法
其他社区产品如何解决问题 2

arcsin1 · 2020-08-30T06:05:59Z

来个设计思路示意图: (view 是【0，1】)

src/plots/bullet/adaptor.ts

src/plots/bullet/types.ts

hustcc · 2020-09-07T02:29:29Z

__tests__/unit/plots/bullet/data-spec.ts

+      rangeField: 'ranges',
+      targetField: 'target',
+      xField: 'title',
+    });


这个单测逻辑写的不对，应该单独为 transformData 进行写单测。现在这个单测相当于是断言 bullet 的数据处理逻辑一定走 transformData 这个方法，而至于 transformData 内部是否有修改，修改是否正确，测试不出来~

hustcc · 2020-09-07T02:34:17Z

src/plots/bullet/adaptor.ts

+    target: {
+      min,
+      max,
+      sync: true,


nit: 这里是要吧 measure、range、target 都同步 sync。所以应该做法是都设置 sync: 'a-same-key' 即可。sync: true 的意思，是自动以字段名称为 key 去同步。

这里的 measure， range，target 是不是应该直接是 [measureField], [rangeField], [targetField] ?

已经转换过了不能直接用measureField这种因为他是数组

hustcc · 2020-09-07T02:36:38Z

src/plots/bullet/types.ts

+  style?: ShapeAttrs;
+  size?: number;
+};
+export type BulletData = {


这个类型定义应该不需要了吧~

有用 transformData的时候需要

phoema · 2020-09-11T06:11:03Z

大神们，V2 的子弹图能选竖起来的样式吗，包括多子弹图

arcsin1 · 2020-09-11T09:03:13Z

大神们，V2 的子弹图能选竖起来的样式吗，包括多子弹图

会支持的

arcsin1 added 9 commits July 23, 2020 15:37

Merge pull request #1 from antvis/v2

bb55b15

V2

Merge remote-tracking branch 'upstream/v2' into v2

3dd5854

Merge remote-tracking branch 'upstream/v2' into v2

726d453

Merge remote-tracking branch 'upstream/v2' into v2

811fe4e

docs: 增加histogram的文档

68d20b8

增加histogram的文档

style: 简化代码

95acfe1

Merge remote-tracking branch 'upstream/v2' into v2

7164ae6

Merge branch 'v2' into v2-histogram

2ee7900

style: rebase和简化代码

7bc6f92

auto-add-label bot added the enhancement New feature or request label Aug 13, 2020

pr-triage bot added the PR: unreviewed label Aug 13, 2020

hustcc reviewed Aug 13, 2020

View reviewed changes

src/plots/bullet/adaptor.ts Outdated Show resolved Hide resolved

hustcc changed the base branch from v2 to master August 14, 2020 07:48

arcsin1 and others added 2 commits August 17, 2020 16:13

Merge branch 'v2-histogram' of https://github.com/arcsin1/G2Plot into…

06aee04

… v2-histogram

feat(g2-plot): 添加雷达图

7ff552f

visiky linked an issue Aug 21, 2020 that may be closed by this pull request

子弹图中的legend无法显示 #1442

Closed

visiky removed a link to an issue Aug 21, 2020

子弹图中的legend无法显示 #1442

Closed

arcsin1 closed this Aug 21, 2020

arcsin1 reopened this Aug 21, 2020

arcsin1 force-pushed the v2-bullet branch from b81084e to 45cf9d3 Compare August 25, 2020 05:52

hustcc reviewed Aug 29, 2020

View reviewed changes

src/plots/bullet/utils.ts Outdated Show resolved Hide resolved

hustcc reviewed Aug 29, 2020

View reviewed changes

src/plots/bullet/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed Aug 29, 2020

View reviewed changes

src/plots/bullet/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed Aug 29, 2020

View reviewed changes

src/plots/bullet/types.ts Outdated Show resolved Hide resolved

hustcc reviewed Aug 29, 2020

View reviewed changes

src/plots/bullet/types.ts Outdated Show resolved Hide resolved

visiky reviewed Sep 4, 2020

View reviewed changes

src/plots/bullet/adaptor.ts Show resolved Hide resolved

hustcc reviewed Sep 4, 2020

View reviewed changes

src/plots/bullet/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed Sep 4, 2020

View reviewed changes

src/plots/bullet/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed Sep 4, 2020

View reviewed changes

src/plots/bullet/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed Sep 4, 2020

View reviewed changes

src/plots/bullet/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed Sep 4, 2020

View reviewed changes

src/plots/bullet/types.ts Show resolved Hide resolved

arcsin1 added 2 commits September 7, 2020 09:57

Merge remote-tracking branch 'upstream/master'

56f1a3e

feat: 新增v2bullet子弹图

8d56005

arcsin1 force-pushed the v2-bullet branch from 6a047fb to 8d56005 Compare September 7, 2020 02:14

hustcc reviewed Sep 7, 2020

View reviewed changes

hustcc self-requested a review September 7, 2020 02:45

hustcc approved these changes Sep 7, 2020

View reviewed changes

hustcc merged commit 1210ff4 into antvis:master Sep 7, 2020

pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: v2版子弹图bullet初稿 #1427

feat: v2版子弹图bullet初稿 #1427

arcsin1 commented Aug 13, 2020 •

edited by hustcc

Loading

visiky commented Aug 21, 2020 •

edited

Loading

arcsin1 commented Aug 21, 2020

visiky commented Aug 21, 2020

arcsin1 commented Aug 21, 2020

arcsin1 commented Aug 21, 2020

arcsin1 commented Aug 25, 2020 •

edited

Loading

hustcc Aug 29, 2020 •

edited

Loading

hustcc commented Aug 29, 2020

arcsin1 commented Aug 30, 2020

hustcc Sep 7, 2020

hustcc Sep 7, 2020 •

edited

Loading

hustcc Sep 7, 2020

arcsin1 Sep 7, 2020

hustcc Sep 7, 2020

arcsin1 Sep 7, 2020

phoema commented Sep 11, 2020

arcsin1 commented Sep 11, 2020

feat: v2版子弹图bullet初稿 #1427

feat: v2版子弹图bullet初稿 #1427

Conversation

arcsin1 commented Aug 13, 2020 • edited by hustcc Loading

visiky commented Aug 21, 2020 • edited Loading

arcsin1 commented Aug 21, 2020

visiky commented Aug 21, 2020

arcsin1 commented Aug 21, 2020

arcsin1 commented Aug 21, 2020

arcsin1 commented Aug 25, 2020 • edited Loading

hustcc Aug 29, 2020 • edited Loading

Choose a reason for hiding this comment

hustcc commented Aug 29, 2020

arcsin1 commented Aug 30, 2020

hustcc Sep 7, 2020

Choose a reason for hiding this comment

hustcc Sep 7, 2020 • edited Loading

Choose a reason for hiding this comment

hustcc Sep 7, 2020

Choose a reason for hiding this comment

arcsin1 Sep 7, 2020

Choose a reason for hiding this comment

hustcc Sep 7, 2020

Choose a reason for hiding this comment

arcsin1 Sep 7, 2020

Choose a reason for hiding this comment

phoema commented Sep 11, 2020

arcsin1 commented Sep 11, 2020

arcsin1 commented Aug 13, 2020 •

edited by hustcc

Loading

visiky commented Aug 21, 2020 •

edited

Loading

arcsin1 commented Aug 25, 2020 •

edited

Loading

hustcc Aug 29, 2020 •

edited

Loading

hustcc Sep 7, 2020 •

edited

Loading